Problem/Motivation
Follow-up to #3303902: Move ProjectInfo class into package_manager
The Update module will only fetch the Update XML for projects that are in the active codebase.
For the Project Browser it will need to validate projects that are not in the active code base.
This would also allow us to do #3303900: Remove PreApply check in PackagesInstalledWithComposerValidator
Steps to reproduce
Proposed resolution
Add the ability for ProjectInfo to get release information for projects not currently in the active codebase. A started to this in the branch https://git.drupalcode.org/issue/automatic_updates-3303902/-/tree/330390...
Remaining tasks
follow-up #3307355: Add support for new Drupal project dependencies automatic_updates_extensions
Issue fork automatic_updates-3307163
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3307163-update-processor
changes, plain diff MR !459
- 3307163-new-projects-xml
changes, plain diff MR !456
Comments
Comment #2
tedbowComment #3
tedbow#3303902: Move ProjectInfo class into package_manager is done, so unpostoning
Comment #5
tedbowComment #6
tedbowComment #7
traviscarden commentedPer our discussion, @tedbow, I'm marking this "Needs work" for more explanatory comments in the code.
Comment #8
tedbow@TravisCarden updated the comments around the interaction with the UPdate module services. I changed the functionality slightly and will comment on the MR
Comment #9
tedbowComment #11
tedbowI have created a new merge request that instead of using the Update module's update processor service creates new package manager update processor service. This eliminates the possibility of a project that we are fetching that is not in the active code getting into the cache of the Update module itself and then being return from global functions such as
update_get_available(). It also eliminates the need for use to assume how the update module stores its cache through calls to `\Drupal::keyValueExpirable('update_available_releases')`.I will comment more on MR
Comment #12
tedbowAfter talking with @TravisCarden we decided this issue is good to commit and I have opened a follow-up to determine if we should just use the new Update processor service for all XML #3308235: Do not use the Update modules cache of UPdate XML so we can control how long it is cached
Comment #13
tedbowComment #16
tedbowthanks for the feedback on this @TravisCarden!
Comment #18
tedbow