Problem/Motivation

In \Drupal\automatic_updates_extensions\Validator\PackagesInstalledWithComposerValidator we add an error if any Drupal Project Composer packages are in stage that aren't in active Composer.

This is because the Update module will only fetch the Update XML for projects that are in the active codebase.

This problem doesn't make Automatic Updates Extensions unusable because you can still update projects as long as they don't add new dependencies that are Drupal projects. But it will be problem that Project Browser has to solve.

Proposed resolution

Once these issue are completed

  1. #3307369: Validate all changed or updated Drupal projects with Update XML
  2. #3305568: Create a validator that detects duplicate info.yml files in the stage on apply
  3. #3305564: Create a validator to stop newly installed packages from overwriting existing directories on apply

It should not matter if newly installed packages were not installed via Composer in PreApply. the above validators will handle that and modules that use Package will not have to check that themselve.

so we can remove the PreApply check in PackagesInstalledWithComposerValidator

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Issue summary: View changes
tedbow’s picture

After writing up this I am wondering if just moving ProjectInfo into package manager and adding the ability to get info on projects not in current codebase should really be its own issue because it is used many places so it will be a huge diff.

tedbow’s picture

tedbow’s picture

tedbow’s picture

tedbow’s picture

tedbow’s picture

Status: Active » Postponed

Postponed based on issues in summary

tedbow’s picture

Status: Postponed » Active

Actually un-postponing. We can actually do start to change the validator and remove the test coverage now and then wait to merge until the other issues are done

tim.plunkett’s picture

Removing tag per discussion

phenaproxima’s picture

Title: Remove PreApply check in PackagesInstalledWithComposerValidator » [PP-1] Remove PreApply check in PackagesInstalledWithComposerValidator
Status: Active » Postponed

Only one blocker left.

phenaproxima’s picture

Title: [PP-1] Remove PreApply check in PackagesInstalledWithComposerValidator » Remove PreApply check in PackagesInstalledWithComposerValidator
Status: Postponed » Needs work

Final blocker is in!

omkar.podey made their first commit to this issue’s fork.

omkar.podey’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Status: Needs review » Reviewed & tested by the community

Looks ready to go!

phenaproxima’s picture

Status: Reviewed & tested by the community » Fixed

Sheesh, GitLab put up a real fight about merging this. What a nightmare.

However, I won! Merged into 8.x-2.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

Issue tags: +core-mvp
wim leers’s picture

Issue tags: -core-mvp +contrib-only

Cannot be core-mvp because AUE.