Problem/Motivation
In \Drupal\automatic_updates_extensions\Validator\PackagesInstalledWithComposerValidator we add an error if any Drupal Project Composer packages are in stage that aren't in active Composer.
This is because the Update module will only fetch the Update XML for projects that are in the active codebase.
This problem doesn't make Automatic Updates Extensions unusable because you can still update projects as long as they don't add new dependencies that are Drupal projects. But it will be problem that Project Browser has to solve.
Proposed resolution
Once these issue are completed
- #3307369: Validate all changed or updated Drupal projects with Update XML
- #3305568: Create a validator that detects duplicate info.yml files in the stage on apply
- #3305564: Create a validator to stop newly installed packages from overwriting existing directories on apply
It should not matter if newly installed packages were not installed via Composer in PreApply. the above validators will handle that and modules that use Package will not have to check that themselve.
so we can remove the PreApply check in PackagesInstalledWithComposerValidator
Issue fork automatic_updates-3303900
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
tedbowComment #3
tedbowAfter writing up this I am wondering if just moving ProjectInfo into package manager and adding the ability to get info on projects not in current codebase should really be its own issue because it is used many places so it will be a huge diff.
Comment #4
tedbowComment #5
tedbowcreated #3303902: Move ProjectInfo class into package_manager
Postponing this on that issue
Comment #6
tedbow#3303902: Move ProjectInfo class into package_manager is done!
Comment #7
tedbowComment #8
tedbowPostponed based on issues in summary
Comment #9
tedbowActually un-postponing. We can actually do start to change the validator and remove the test coverage now and then wait to merge until the other issues are done
Comment #10
tim.plunkettRemoving tag per discussion
Comment #11
phenaproximaOnly one blocker left.
Comment #12
phenaproximaFinal blocker is in!
Comment #15
omkar.podey commentedComment #16
phenaproximaLooks ready to go!
Comment #18
phenaproximaSheesh, GitLab put up a real fight about merging this. What a nightmare.
However, I won! Merged into 8.x-2.x. Thanks!
Comment #20
tedbowComment #21
wim leersCannot be
core-mvpbecause AUE.