Problem/Motivation

Currently in \Drupal\automatic_updates_extensions\Validator\PackagesInstalledWithComposerValidator on PreApplyEvent we check if any newly added packages are DRuapl projects that aren't in that active composer. this is because we can't get Drupal Update XML for projects that are not in the active codebase

Once #3307163: Add the ability to ProjectInfo handle projects not in the active codebase is in we could do that!🎉

Proposed resolution

Postponed on #3307163: Add the ability to ProjectInfo handle projects not in the active codebase and #3307369: Validate all changed or updated Drupal projects with Update XML

  1. Don't subscribe to `PreApply` in PackagesInstalledWithComposerValidator
  2. Update \Drupal\automatic_updates_extensions\Validator\UpdateReleaseValidator to check not only update Drupal project packages but also newly installed ones this validator will be removed in in #3307369: Validate all changed or updated Drupal projects with Update XML
  3. #3313319: Remove \Drupal\automatic_updates_extensions\Validator\UpdateReleaseValidator

Comments

tedbow created an issue. See original summary.

tedbow’s picture

Issue summary: View changes
Status: Active » Postponed
Related issues: +#3307369: Validate all changed or updated Drupal projects with Update XML
tedbow’s picture

Status: Postponed » Active
tedbow’s picture

Issue summary: View changes

we just need to do #3313319: Remove \Drupal\automatic_updates_extensions\Validator\UpdateReleaseValidator now

But should we add test coverage to automatic_updates_extensions to prove that explicitly allows new dependencies?

tedbow’s picture

Need to explain why we might need test coverage in the summary

tedbow’s picture

Component: Code » Automatic Updates Extensions
tedbow’s picture

Issue tags: +contrib-only

Just triaging but this might not be needed anymore

tedbow’s picture

Version: 8.x-2.x-dev » 3.0.x-dev