Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Meeting
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
31 Aug 2022 at 12:47 UTC
Updated:
14 Sep 2022 at 12:49 UTC
Jump to comment: Most recent
| timplunkett (he/him) | @narendraR++ |
| fjgarlin | following this one closely. I’ve seen part of the code re-factoring and it’s looking great.the key function that reads data from drupal.org (the mock for now) and makes it PB friendly is still this one _project_browser_populate_from_fixture right? |
| chrisfromredfin | The general idea (in mine) is that $current_source->getProjects($request->query->all()); -- the interface "getProjects" method goes to WHATEVER backend (hell could be a google sheet for all we care) and gives it back in a known format. |
| narendraR | I will create a new MR and use @chrisfromredfin code. It will be basically to remove coding standard changes and do work in same module instead of sub-module as discussed with @timplunkett (he/him) and then work on top of it to make api work. |
| chrisfromredfin | Thank you @narendraR ! |
| narendraR | Related to fixture, I am thinking of making it smaller by not adding all Drupal 9 compatible modules. We can have top modules say 1000-2000 as later we will be updating tables from cron. Also processing of the data can be done at the time of fixture creation. Although this can be done as a separate ticket. Thoughts? |
| timplunkett (he/him) | I agree we should limit for now, but I also agree it should be a separate ticket |
| chrisfromredfin | agree on both counts, as above :point_up: |
| chrisfromredfin | with many thanks to srishti.bankar for this work! |
| chrisfromredfin | And with actual collaborators and other people working now, I promise no more direct pushes. Everything will have an issue and a review. :slightly_smiling_face: |
| chrisfromredfin | p.s. @timplunkett (he/him) this one has a new review requested after your feedback: :point_up: |
| timplunkett (he/him) | @Srishti++ |
| chrisfromredfin | (^ aww man why couldn't I find that name?! I tried!) |
| narendraR | I will review this tomorrow. May be loading will appear if some delay is added. |
| chrisfromredfin | I'd be more inclined to look for something else rather than loading... but not sure if that's the right thing. Testing is my weakest spot. :slightly_smiling_face: |
| timplunkett (he/him) | @lauriii might have the most up-to-date info |
| Gábor Hojtsy (he/him) | @lauriii and @justafish were literally discussing it an hour ago |
| Aaron McHale | Aww I wish I could have made it to DevDays, oh well... I'm still interested in the idea that this could be powered using Views, I guess it would be a question of:What's more effort implementing a new JS framework and/or writing a vanilla JS front-end, orAdapting Views to be able to take the API end-point as a data source. |
| chrisfromredfin | #3268636: Convert to GitLab CI |
| AmyJune (volkswagenchick) | I think we are going to include a doc to the contrib.md issue today |
| fjgarlin | doing some suggestions on the installation part… |
| fjgarlin | in that case, I think I’ll wait and then see if I can add anything after contrib.md is sorted |
| jjcs227 | I'll check the installation part anyways. |
| alexpott | @leslieg your video was really good. The distributions initiative is mostly in start up phase at the moment. Everything is quite hand-wavy :slightly_smiling_face: and there’s no organisation to the team yet - it’s a loose collective of people who want to make things better. Hopefully we can be inspired by how well organised and the great team that’s been built for Project Browser. |
| chrisfromredfin | I still feel like we're in startup phase. :laughing: |
| leslieg | Thanks Alex. We were there as well, and still feel like we are to some degree as Chris said. By the time we get to the later phases of the Project Browser where we may be adding themes and distributions, your initiative will be much further along. |
| chrisfromredfin | I liked @hestenet (he/him)’s idea to try and get to a point of "proposing" what we think might work for categories as a starting point for a discussion at Drupalcon. Get a small committee in a "room" together to try and identify that. Go down the spreadsheet I made and see if we can come up with a plan for each term. |
Participants:
timplunkett (he/him), fjgarlin, chrisfromredfin, narendraR, Gábor Hojtsy, Aaron McHale, AmyJune (volkswagenchick), jjcs227, alexpott, leslieg
Comments
Comment #8
chrisfromredfinComment #12
chrisfromredfinComment #13
chrisfromredfin