Problem/Motivation

The 4.0.x branch drops support for versions of Drupal prior to 9.1. It still contains code that provides compatibility with earlier versions.

Proposed resolution

Remove code that provides compatibility with versions of Drupal prior to 9.1.

CommentFileSizeAuthor
#2 3306506-2.patch2.54 KBrlhawk

Issue fork key-3306506

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

rlhawk created an issue. See original summary.

rlhawk’s picture

Status: Active » Needs review
StatusFileSize
new2.54 KB
japerry’s picture

Version: 4.0.x-dev » 8.x-1.x-dev

This should be done once an 8.x-1.x release is made with Drupal 10 support. That'll allow Drupal 8 customers to make the jump to D10 without too much headache.

Personally I'd wait until Drupal 10 / 9.5 lands to get this in. At that point, you can make key module support the LTS version of Drupal 9 only instead of Drupal 9.1, which has been EOL longer than Drupal 8.

jcnventura’s picture

Version: 8.x-1.x-dev » 4.0.x-dev

I don't get the change of version. The maintainer says that he wants to remove code from the new major version of the module. He's free to do whatever he wants in 4.0.x. There's no need to keep junk around in that version.

Also, key 8.x-1.16 is compatible with Drupal 10.

japerry’s picture

Version: 4.0.x-dev » 8.x-1.x-dev

Talked to rlhawk at Drupalcon about versioning, and its likely a new version is not likely anytime soon due to the downstream dependencies. Thus moving this back.

As of Q2 2025, the minimum version can be safely set to Drupal 9.5 without needing to change the major version.

ptmkenny made their first commit to this issue’s fork.

ptmkenny’s picture

The patch no longer applied so I fixed it and converted it to an MR.

rajeshreeputra’s picture

Status: Needs review » Needs work

@ptmkenny, we should update the title, description and MR accordingly to support Drupal core >=10.3 version in 4.x version.

rajeshreeputra’s picture

Title: Remove support for Drupal < 9.1 » Remove support for Drupal core below 10.3 version.
Issue summary: View changes

Update ticket to Drop support of Drupal core version below 10.3.

rajeshreeputra’s picture

Title: Remove support for Drupal core below 10.3 version. » Remove support for Drupal < 9.1
Issue summary: View changes

Keeping this intact instead created separate issue for dropping support of Drupal core below 10.3 version.
#3524922: Drop support of Drupal core below 10.3 version.

ptmkenny’s picture

Status: Needs work » Needs review
japerry’s picture

Status: Needs review » Fixed

Thanks for keeping the Drupal 10 and 9 discussion separate. For 8.x-1.x, 9.1 is ok for now. I also updated the format so its easier to parse in drupalci testing. While there used to be benefits of doing the <12 format (to test betas before release) the lenient composer and drupalci issues make core_version_requirement: '^9.1 || ^10 || ^11' a better format now.

japerry’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.