Improve the navigation on individual module pages

I'll work on that.

Changes was made by me and @diegors.

Can you create an MR for it so the changes can be reviewed and tested. The tests will also run once you do it and they should come up green. Thanks.

Remove the patch file from the commit and created the MR.

MR has a package-lock.json file, and has modified the yarn.lock.
Fixing this.

This issue is a great addition!

I've changed the arrow to the same SVG used on the Claro theme breadcrumb.
The text was also missing the bold font weight.

I wonder, however, if there was a way to use Drupal's top breadcrumb, instead, and if it would make sense from the UX perspective (of course).

Also, the top last breadcrumb ends in 'Browse projects' and the first PB's breadcrumb is 'Browse'

Bare in mind that we are covering both Claro and Seven as admin themes. There is a specific CSS file for each in the repo if needed. Maybe you could save the image so it can be easily re-used and then reference the file rather than loading the full SVG inline?

Also, tests aren't happy (green) yet. You need to make sure that they pass to get the issue moving forward. See the output from the link above in the failed test:

[warn] src/ModulePage.svelte
[warn] Code style issues found in the above file(s). Forgot to run Prettier?
error Command failed with exit code 1.
error Command failed with exit code 1.

So it seems that you need to run prettier, and then re-compile the files.

Using Seven, it could look like this: (not implemented)

Edit: I see the project has already a way to deal with different styles across these themes. The missing changes can be added there.
Edit 2: It looks like themability is an issue in discussion

Bare in mind that we are covering both Claro and Seven as admin themes. There is a specific CSS file for each in the repo if needed.

Seeing two files, named claro.css and seven.css, led me into thinking these were being dynamically loaded, based on the installed admin theme.
Is this not the case?

Here is it looks on Claro after the last commits.

Currently, I don't see any implementation for conditional theming, based on the current active theme.

Conditional theme styling seems to be something that needs to be addressed.

@mpaulo - I think the current implementation works well for both themes. The reason why I mentioned the theme files before was due to the previous iteration, but the current state of the MR has been simplified and works for both themes.

Having said that, the conditional theme styling could be a follow up issue, so feel free to create it.

I added a comment for a small refactoring which should also solve the issue that @rkoller reports.

It was just a comment, not a code change. I'll let @mpaulo do the actual refactoring. Sorry it wasn't very clear.

The issue is in "Needs work", so I wouldn't try to test it again until it's again in "Needs review".

but in the browser i get a 404 no matter if i try it in safari, firefox or edge. not sure what is causing that behavior. :/

Maybe this was from using a hard coded module path. Fixed it.

Also, here is how it looks on Seven:

I think if it looks ok, we can move to NR.

Code-wise, it has the thumbs up from me and I'd mark it as RTBC, but I'll let @rkoller do some testing in case there is anything obvious missing (I'm just looking at the code).

Thanks for addressing the feedback @mpaulo

Opened new MR with an action link.

Tested via Drupalpod, it looks great! I also checked the code. I only made a tiny suggestion, but it could go as is as well, so marking RTBC.

Left small feedback

I think @tim.plunkett's feedback was addressed, but … we're still missing RTL support? Perhaps that's considered out of scope here though?

All the RTL related issues are being fixed in #3316998: Fix RTL margins and alignment of elements in lists and on project page

Change requested in MR

Just want to say the "Back to browsing" link is a much better solution than the faux breadcrumb.

First of all, having two breadcrumbs on the page is confusing. The lower one could mean users won't spot the top one, and then wonder why they they can't go back further than the project browser. The upper one includes the project browser page, so does everything the breadcrumb should do.

Second, the last item in the breadcrumbs should be the page above the level of the current page, so including the project name in the breadcrumb is inconsistent. And if you take that out, all that's left is the Browse level, so renaming it to the "Back to browsing" label makes sense.

I'm sure you all already know all this, but I was considering opening an issue, but found it already resolved.

Found one thing in the MR that needs changing.

Very nice to see the discussion result in an accessible solution that works with minimal code changes. Merged!