$this->t() should be used instead of t() as per coding standards.

CommentFileSizeAuthor
#29 interdiff_26-29.txt7.66 KBslucero
#29 3299960-29.patch13.64 KBslucero
#26 interdiff_23-26.txt392 bytesalanmoreira
#26 3299960-26.patch18.58 KBalanmoreira
#23 updated-patch-3299960-23.patch18.32 KBjatingupta40
#19 3299960-19.patch14.13 KBanoopsingh92
#16 3299960-16.patch13.19 KBanoopsingh92
#13 3299960-13.patch11.65 KBakshaydalvi212
#12 Screenshot from 2022-07-27 17-52-22.png33.14 KBakshaydalvi212
#9 3299960-9.patch10.41 KBlucassc
#7 3299960-7.patch10.62 KBlucassc
#5 3299960-5.patch11.01 KBlucassc
#2 3299960-2.patch18.39 KBMunavijayalakshmi

Issue fork patternkit-3299960

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new 3299960-2.patch18.39 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3299960-2.patch, failed testing. View results

slucero’s picture

slucero
he/him
Primary language English
commented
Version: 9.1.x-dev » 9.1.0-beta4

Hi @Munavijayalakshmi, thank you for posting the contribution! It looks like from the testing results some of the changes in your patch include replacement within static functions where $this is unavailable. Would you mind adjusting the patch to not change those?

lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Status: Needs work » Needs review
StatusFileSize
new 3299960-5.patch11.01 KB

Hello, @Munavijayalakshmi and @slucero!

I applied the patch from #2 and reverted the changes within static functions.

Please, review this.

Status: Needs review » Needs work

The last submitted patch, 5: 3299960-5.patch, failed testing. View results

lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Status: Needs work » Needs review
StatusFileSize
new 3299960-7.patch10.62 KB

Reverted remaining changes within static functions.

Status: Needs review » Needs work

The last submitted patch, 7: 3299960-7.patch, failed testing. View results

lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
StatusFileSize
new 3299960-9.patch10.41 KB

Tests in #7 were still failing, so I tried a new patch now reverting the change in src/Plugin/Derivative/PatternkitBlock.php:177.

Please, review this.

lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 3299960-9.patch, failed testing. View results

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Unassigned » akshaydalvi212
Issue summary: View changes
StatusFileSize
new Screenshot from 2022-07-27 17-52-22.png33.14 KB

Hello,

Thanks for the patch,

While reviewing the patch, still encountered some similar warnings as mentioned below:

Need to update patch #9 to eliminate the remaining warnings as well.

Thanks and regards

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3299960-13.patch11.65 KB

Hello,

Providing the updated patch which can eliminate the remaining warning related to t() tobe replaced by $this->t():

Kindly review and provide feedback on the same.

Thanks and regards

Status: Needs review » Needs work

The last submitted patch, 13: 3299960-13.patch, failed testing. View results

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: Unassigned » anoopsingh92
anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
StatusFileSize
new 3299960-16.patch13.19 KB

Hi, I have applied a patch please review this. Thanks

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Assigned: anoopsingh92 » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 16: 3299960-16.patch, failed testing. View results

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
StatusFileSize
new 3299960-19.patch14.13 KB

Review this patch.

anoopsingh92’s picture

anoopsingh92
Location Rajasthan, India
commented
Status: Needs work » Needs review
jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review this patch.

Status: Needs review » Needs work

The last submitted patch, 19: 3299960-19.patch, failed testing. View results

jatingupta40’s picture

jatingupta40 commented
Assigned: jatingupta40 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new updated-patch-3299960-23.patch18.32 KB

Providing a patch, please review.
Thanks

Status: Needs review » Needs work

The last submitted patch, 23: updated-patch-3299960-23.patch, failed testing. View results

alanmoreira’s picture

alanmoreira commented
Assigned: Unassigned » alanmoreira

I'll work on this =)

alanmoreira’s picture

alanmoreira commented
Assigned: alanmoreira » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3299960-26.patch18.58 KB
new interdiff_23-26.txt392 bytes

New patch done. Leaving unassigned and changing status to "Needs review"

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: Unassigned » Tauany Bueno

hi! i'll review it :)

Tauany Bueno’s picture

Tauany Bueno commented
Assigned: Tauany Bueno » Unassigned
Status: Needs review » Reviewed & tested by the community

Hello!!

I reviewed the patches and ran phpcs, and didn't find any warning regarding t() calls.
Changing to RTBC :)

slucero’s picture

slucero
he/him
Primary language English
commented
Parent issue: » #3296167: Beta 5 Release Plan
StatusFileSize
new 3299960-29.patch13.64 KB
new interdiff_26-29.txt7.66 KB

I found some additional places that weren't in an object context that got changed and I've reverted those. Aside from those tweaks, this should be good to go.

Thanks for the contributions everybody!

  • slucero authored b1932fc on 9.1.x 
    Issue #3299960 by anoopsingh92, lucassc, slucero, akshaydalvi212,...
slucero’s picture

slucero
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Merged! Thanks for the work everybody!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.