Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#12 After_patch.png253.04 KBdeepalij
#12 Before_patch.png235.01 KBdeepalij
#10 interdiff_4_10.txt482 bytesameymudras
#10 3299573-10.patch2.44 KBameymudras
#6 Screenshot from 2022-07-28 18-02-43.png151.14 KBjatingupta40
#4 d10_compatibilty-3299573-4.patch1.9 KBatul_ghate
#2 zurb_twentytwenty.2.0.x-dev.rector.patch1.09 KBproject update bot

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new zurb_twentytwenty.2.0.x-dev.rector.patch1.09 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate
Issue summary: View changes

Hi,
I will review this patch

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Issue tags: +Drupal 10 porting day
StatusFileSize
new d10_compatibilty-3299573-4.patch1.9 KB

I have reviewed the #2 patch and tested the module compatibility using the upgrade status module. Please review the requested changes for Drupal 10 compatibility.

jatingupta40’s picture

jatingupta40 commented
Assigned: Unassigned » jatingupta40

I will review this patch.

jatingupta40’s picture

jatingupta40 commented
Assigned: jatingupta40 » Unassigned
StatusFileSize
new Screenshot from 2022-07-28 18-02-43.png151.14 KB

I got 2 warnings (attached-image). I tried adding the library from 'https://github.com/zurb/twentytwenty', but still it didn't worked for me. So, moving to Need Work.

jatingupta40’s picture

jatingupta40 commented
Status: Needs review » Needs work
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thank you both for your help on this issue.

@atul ghate In #4 you added a new patch but don't explain why you added it. Also, please add an interdiff when making changes to existing patches: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa...

@JatinGupta40 I assume you tested the patch in #4. Perhaps note the comment number so it's clear which patch you are testing.

ameymudras’s picture

ameymudras commented
Assigned: Unassigned » ameymudras
ameymudras’s picture

ameymudras commented
Assigned: ameymudras » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 3299573-10.patch2.44 KB
new interdiff_4_10.txt482 bytes

Tested the module on 9.5.x and 10.0.x along with the patch #4 because the changes are a good addition and remove deprecated code. Following are my findings:

1. The upgrade status warnings mentioned in #6 is because library is not added and can be skipped
2. The patch applies cleanly but there was an error in the console
drupal.js?v=10.0.0-dev:16 Uncaught TypeError: $(...).once is not a function

Fixed it in the patch provided

deepalij’s picture

deepalij commented
Assigned: Unassigned » deepalij
deepalij’s picture

deepalij commented
Assigned: deepalij » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before_patch.png235.01 KB
new After_patch.png253.04 KB

Verified and tested patch #10 on Drupal 10.0.x.
Please see the below findings:

1. Patch applied successfully.
2. The module can be installed without any issues/warnings
3. Console error has been fixed and not found any such error.

Please find the attached screenshots for the reference
Marking this as RTBC

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

I'm changing this back to "Needs review" so that further patches can be included per the issue summary. We can let the maintainer of the module decide whether they would prefer to close the issue to further patches.

If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks everyone for participating in porting day!

Definitely looks like there is a *good* patch that's been tested and is ready to be committed.

@DeepaliJ It's not clear to me if tested the module itself or just that it installs without issues.

It's unlikely the bot will provide another patch that would include different information. But there is not a consensus right now between the Drupal 10 Readiness team and event mentors whether these should be moved to RTBC or not. IMO, this is a good example to move to RTBC as it's an updated patch that captures things the bot had not. But, I will leave as is for now.

deepalij’s picture

deepalij commented

Hi @kristen I have tested the issue by installing the module.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue tags: +Needs manual testing

Based on discussions on marking bot issues RTBC in the #d10readiness channel a few weeks ago, we have agreed this should be done after a person has tested and the patch looks ready.

But, since only the installation was tested and the module wasn't tested, tagging this for manual testing on Drupal 10 for the module functionality.

@DeepaliJ Note that you do not need to include screenshots of the module installation. Thanks.

deepalij’s picture

deepalij commented
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes

Working during porting day.

This still needs manual testing.

xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented

Thanks for all the work being done for this handy module!

I will manually test the Drupal 10 version before creating the official Drupal 10 tag.

  • xmacinfo committed f28f7ef7 on 2.0.x authored by ameymudras 
    Issue #3299573 by ameymudras, Project Update Bot, atul ghate: Automated...
xmacinfo’s picture

xmacinfo
he/him
Primary language French
Location Canada
commented
Status: Needs review » Fixed

Pushed to the dev branch.

Thank you everyone for your precious work!

kevinquillen’s picture

kevinquillen commented

Great work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.