Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | Screenshot from 2022-08-04 14-14-20.png | 230.06 KB | sharayurajput |
| #6 | Screenshot from 2022-08-02 17-02-08.png | 19.69 KB | sharayurajput |
| #2 | social_auth_google.3.x-dev.rector.patch | 796 bytes | project update bot |
Issue fork social_auth_google-3298116
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #5
sharayurajput commentedI will review this issue
Comment #6
sharayurajput commentedPatch is applied successfully but when we try to enable module using extend tab it shows the error -
The website encountered an unexpected error please try again later alse added screenshot
Also checked this module with MR also getting same error
Comment #7
sharayurajput commentedComment #8
wells@sharayurajput when you encounter an error like that you can usually find more information about what caused the error by visiting Admin > Status > Recent log messages (if you have the database logging module enabled).
Providing additional details about the error may make it easier for others to help troubleshoot here.
Comment #9
balintpekkerIt would be nice to know what the actual issue is in @sharayurajput's testing, as I was able to install the module without any issues in 10.0.0-alpha6 as well as D9.5 and D9.4.
Also, to add to @wells comment, if you are only seeing the same message in the logs, you can change the setting in Configuration > Logging and errors to 'All messages, with backtrace information'. After that you should be able to see a log message which can provide maintainers/developers information about the issue.
Comment #10
sharayurajput commentedOK I'll check this once again
Comment #11
sharayurajput commentedgetting this error in Recent logs messages
Comment #12
wells@sharayurajput how did you install the module? That error message makes it sound like the Social Auth module is not installed.
If you’re using some method other than composer to install the module you must also download and install the Social API and Social Auth modules as they are both required dependencies.
Comment #13
jatingupta40 commentedI will review the MR, and if needed then will also provide the suitable required changes.
Thanks.
Comment #14
jatingupta40 commentedAs mentioned in #12, I at first installed the required dependent modules ie - Social API and Social Auth modules, and then installed this module.
The MR at #4 works absolutely fine and got me error while installing in Drupal 9.4 and Drupal 10.
Also,
1. There is no such error report when checked in Reports > Recent Log Messages.
2. The Upgrade Status module shows this module as fully compatible without any error message.
So, shifting it to RTBC.
Thanks.
Comment #16
wellsThanks, all! MR 2 is merged.
Comment #18
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips