Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

CommentFileSizeAuthor
#21 3297809-21.patch13.73 KBandypost
#21 interdiff.txt3.26 KBandypost
#19 panels_everywhere-n3297809-19.patch11.27 KBdamienmckenna
#19 panels_everywhere-n3297809-19.interdiff.txt614 bytesdamienmckenna
#17 3297809-17.patch10.85 KBandypost
#17 interdiff.txt3.27 KBandypost
#16 3297809-16.patch10.86 KBandypost
#16 interdiff.txt3.53 KBandypost
#15 3297809-14.patch7.23 KBandypost
#15 interdiff.txt520 bytesandypost
#13 3297809-13.patch7.77 KBandypost
#10 3297809-10.patch3.87 KBandypost
#3 panels_everywhere.4.x-dev.rector.patch3.06 KBproject update bot
#3 interdiff-last-bot.6659452.txt323 bytesproject update bot
#2 panels_everywhere.4.x-dev.rector.patch2.84 KBproject update bot

Issue fork panels_everywhere-3297809

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new panels_everywhere.4.x-dev.rector.patch2.84 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
project update bot’s picture

project update bot commented
StatusFileSize
new interdiff-last-bot.6659452.txt323 bytes
new panels_everywhere.4.x-dev.rector.patch3.06 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.1, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #145

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.25
  2. palantirnet/drupal-rector: 0.13.1
project update bot’s picture

project update bot commented
Issue summary: View changes

Updating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue summary: View changes
Status: Needs review » Needs work

It needs to change composer.json and info file

vacho made their first commit to this issue’s fork.

vacho opened merge request !1

vacho’s picture

vacho commented

I added to MR changes at composer.json and .info. please review.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new 3297809-10.patch3.87 KB

Somehow tests not started for MR, checking patch

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work

Lots of deprecated calls revealed

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3352307: Change ctools dependency from ^3.12 to ^3.12 || ^4.0 to allow for a smooth upgrade process
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new 3297809-13.patch7.77 KB

Few tests still fail

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3332913: Fix PHP 8.2 deprecation notices and D10.1 compatibility

test failure are from ctools #3332913: Fix PHP 8.2 deprecation notices and D10.1 compatibility

But the failure caused by added assert()

AssertionError: Route page_manager.page_view_some_page_id_some_variant_id has broken overridden_route_name in /var/www/html/modules/contrib/panels_everywhere/src/Routing/PanelsEverywhereRouteSubscriber.php:109

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt520 bytes
new 3297809-14.patch7.23 KB

new test without assert

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta
StatusFileSize
new interdiff.txt3.53 KB
new 3297809-16.patch10.86 KB

Front page test has changed since #3111409: Add new Olivero frontend theme to Drupal 9.1 core as beta

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt3.27 KB
new 3297809-17.patch10.85 KB

curly braces could be removed from last variable (phpstorm complains about it), added to MR and here's interdiff and patch to run tests

andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/tests/src/Functional/PanelsEverywhereTest.php
@@ -53,7 +53,7 @@ class PanelsEverywhereTest extends PanelsEverywhereBrowserTestBase {
-    $pageText = 'No front page content has been created yet.';
+    $pageText = "You haven’t created any frontpage content yet.";

This comes from Olivero (core 9.1)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panels_everywhere-n3297809-19.interdiff.txt614 bytes
new panels_everywhere-n3297809-19.patch11.27 KB

Trying to see if this will fix the following error: Creation of dynamic property Drupal\panels_everywhere\Plugin\DisplayVariant\PanelsEverywhereDisplayVariant::$conditionManager is deprecated

andypost’s picture

andypost
he/him
Primary language Russian
commented

It should be inherited in ctools/Plugin/DisplayVariant/BlockDisplayVariant.php and fixed via #3332913: Fix PHP 8.2 deprecation notices and D10.1 compatibility

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new interdiff.txt3.26 KB
new 3297809-21.patch13.73 KB

Looking at implementation this fixes needed to unit test to pass, interdiff vs #17 as *.2 compatibility require to fix ctools

Drupal\Tests\panels_everywhere\Functional\PanelsEverywhereTest::testOtherPages
Exception: Deprecated function: Creation of dynamic property Drupal\panels_everywhere\Plugin\DisplayVariant\PanelsEverywhereDisplayVariant::$conditionManager is deprecated
Drupal\ctools\Plugin\DisplayVariant\BlockDisplayVariant->__construct()() (Line: 94)
andypost’s picture

andypost
he/him
Primary language Russian
commented 
+++ b/src/EventSubscriber/PanelsEverywherePageDisplayVariantSubscriber.php
@@ -152,7 +152,7 @@ class PanelsEverywherePageDisplayVariantSubscriber implements EventSubscriberInt
-  static function getSubscribedEvents() {
+  static function getSubscribedEvents(): array {

needed for 10.1 - future proof compatibility from SF

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Gonna merge as MR and release new alpha

  • andypost committed ed111358 on 8.x-4.x authored by vacho 
    Issue #3297809 by andypost, Project Update Bot, vacho, DamienMcKenna:...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Filed follow-up #3358594: Fix overridden_route_name should not be empty

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.