Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
- Some deprecation notices pop up with PHP 8.2
Deprecated function: Creation of dynamic property ... is deprecated
Also test fail on Drupal 10.1
Proposed resolution
- Attached MR fixes notices I came across
- also fixed CToolsViewsBasicViewBlockTest to use the starterkit_theme as 8.x-3.x doing
- fixed testing on D10.1 after #3061266: Prefix block machine name suggestions with the theme machine name
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3332913-12-9.5.patch | 8.25 KB | andypost |
| #12 | interdiff.txt | 2.72 KB | andypost |
Issue fork ctools-3332913
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
rosk0Comment #4
rosk0CToolsViewsBasicViewBlockTestuses removed in Drupal 10classytheme - needs update.Comment #5
rosk0It's unclear to me why Composer decides to use
laminas/laminas-feed2.17.0 in Drupal 9 tests when 2.20.0 is available and compatible with PHP 8.2.Comment #6
andypostHere's the same as MR patch but for PHP 8.1
Comment #7
andypostOne more patch to fix
17:04:06 PHP Deprecated: a:5:{s:11:"deprecation";s:104:"Creation of dynamic property Drupal\Tests\ctools\Functional\CToolsWizardTest::$dumpHeaders is deprecated";s:5:"class";s:47:"Drupal\Tests\ctools\Functional\CToolsWizardTest";s:6:"method";s:15:"testWizardSteps";s:15:"triggering_file";s:78:"/var/www/html/modules/contrib/ctools/tests/src/Functional/CToolsWizardTest.php";s:11:"files_stack";a:7:{i:0;s:78:"/var/www/html/modules/contrib/ctools/tests/src/Functional/CToolsWizardTest.php";i:1;s:43:"/var/www/html/sites/simpletest/TestCase.php";i:2;s:43:"/var/www/html/sites/simpletest/TestCase.php";i:3;s:65:"/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php";i:4;s:43:"/var/www/html/sites/simpletest/TestCase.php";i:5;s:19:"Standard input code";i:6;s:19:"Standard input code";}} in /var/www/html/vendor/symfony/phpunit-bridge/Legacy/SymfonyTestsListenerTrait.php on line 284Comment #8
andypostSet theme to claro (fix #4) but test shows that variant getting wrong region list from theme
Comment #9
andypostreplace region name
Comment #10
andypostNow all tests passing on 9.5.x and 10.0/10.1
Comment #11
andypostPatch for 8.x-3.x, MR is for 4.0.x
Comment #12
andypostFix last broken test for 8.x-3.x
Comment #13
andypostbetter title
Comment #14
andypostGuzzle issue is from core #3281667: Come up with a way to allow core-recommended (and tarballs?) to install Guzzle 7 for PHP 8.1 compatibility and Laminas-feed 2.19 for PHP 8.2 compatibility
Comment #15
andypostThis is a blocker for panels everywhere compatibility with core 10.1 and PHP 8.2
Comment #16
rajeshreeputrachanges looks good.
Comment #17
japerryFixed!
Comment #19
andypostThank you a lit, new release is https://www.drupal.org/project/ctools/releases/4.0.4
Comment #21
joseph.olstadthis should go into a release, one of these commits fixes the analyze command provided by upgrade_status used for upgrading modules to get them upgraded from D9 to D10.
Comment #22
andypostBoth releases contain it
- https://www.drupal.org/project/ctools/releases/8.x-3.14
- https://www.drupal.org/project/ctools/releases/4.0.4
Comment #23
joseph.olstadthe May 17th commits for the 3x branch, one of those.
There's something missing from 3.14 that is in 3.x-dev, possibly 3 commits I thought this was one of them.
3.15 should be tagged
3.x-dev fixes a bug where upgrade_status crashes on certain code scans . Upgrading to 3.x-dev of ctools fixes it after a cache rebuild. Would prefer 3.15