Problem/Motivation

There's D10 compatible releases starting with https://www.drupal.org/project/ctools/releases/4.0.0

Proposed resolution

  • Change drupal/ctools to ^3.12 || ^4.0 in the composer.josn file.

Remaining tasks

patch/review/commit

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3352307-2.patch341 bytesandypost

Issue fork panels-3352307

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

andypost created an issue. See original summary.

andypost’s picture

Status: Active » Needs review
StatusFileSize
new341 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 3352307-2.patch, failed testing. View results

rajab natshah’s picture

To ensure smoother updates, I suggest using the version constraint "^3.12 || ^4.0".
This will help prevent a large number of modules from encountering a blocker issue.

In the case of the "Total Control Admin Dashboard" module, you can find the relevant configuration in its composer.json file at the following link: Total Control Admin Dashboard - composer.json

The module has utilized the following dependencies:

    "drupal/ctools": "~3.0 || ~4.0",
    "drupal/panels": "~4.0",
    "drupal/page_manager": "*"
rajab natshah’s picture

Hoping for a smoother update process with "^3.12 || ^4.0"

rajab natshah’s picture

Status: Needs work » Needs review
rajab natshah’s picture

Priority: Normal » Major
xem8vfdh’s picture

I agree with #5

xem8vfdh’s picture

xem8vfdh’s picture

Status: Needs review » Reviewed & tested by the community

#5 works for me

rajab natshah’s picture

Priority: Major » Critical

To allow for a smooth upgrade process.
Hoping for a commit and a soft release to support Drupal 10
Other modules switched to use ctools ~4.0 and D10

rajab natshah’s picture

Title: Upgrade ctools dependency to ^4.0 » Change ctools dependency from ^3.12 to ^3.12 || ^4.0 to allow for a smooth upgrade process
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Only for testing:
Having the issue fork in the composer.json file.
In the repositories

  "repositories": {
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8",
      "exclude": [
        "drupal/panels"
      ]
    },
    "drupal/panels": {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/panels-3352307.git"
    }
  },

and in require

  "require": {
    "drupal/core": "~10.0",
    "drupal/ctools": "~4.0.0",
    "drupal/panels": "dev-3352307-upgrade-ctools-dependency as 4.7.0",
  },
xem8vfdh’s picture

you're doing great @Rajab Natshah!

Is there anything else we users can do here or are we simply waiting on maintainers to jump on this?

joelpittet’s picture

Status: Reviewed & tested by the community » Fixed

joelpittet’s picture

Thanks @andypost and @Rajab Natshah for the patch. I've committed it for a new release soon.

xem8vfdh’s picture

@joelpittet, is there any way we can get a new release that includes this fix so those of us blocked can move to ctools 4.x?

joelpittet’s picture

The failing test for IPE needs fixing before the release.

xem8vfdh’s picture

can you point me to a build failure or (more ideally) an issue for tracking the outstanding IPE test issue? I cant try to work on it. Also, is this the only thing holding back a new release?

rajab natshah’s picture

Hoping for a release.
To have a smooth upgrade process for projects.

xem8vfdh’s picture

thanks @Rajab Natshah, I'm hoping for a release too :)

xem8vfdh’s picture

@joelpittet, any progress on the failing IPE test? If not, can you point me to the test runner failure and I can try to take a look?

rajab natshah’s picture

This is a blocker for upgrading to Drupal 10
Please, help us to have a smoother upgrade way
Only a tag release

joseph.olstad’s picture

@Rajab Natshah,
I believe @joelpittet is holding off a tagged release due to the HEAD test failure with IPE

#3383474: Fix HEAD test failures for 4.x
https://www.drupal.org/pift-ci-job/2749558

It would be great to get assistance with this, I sorted through a few issues already, there's one section that's failing still and should be reviewed for action plan.

xem8vfdh’s picture

Thanks @joseph.olstad. Is there documentation somewhere for how I can setup a testing environment to duplicate these failures? If I can get that set up I can do my best to take a look at resolving them.

joseph.olstad’s picture

@xeM8VfDh if you have issues running tests locally you can trigger the ci on #3383474: Fix HEAD test failures for 4.x
by uploading your patch

Otherwise you can look at the documentation here:
https://www.drupal.org/docs/develop/automated-testing
although I had a quick look, this documentation doesn't explain how to run a contrib module test locally.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Hoping for a tag release.
To have a smoother upgrade process for projects.

supreetam09’s picture

We need a new tag for this. Upgrade is blocked.

xem8vfdh’s picture

Agreed