Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | Error-ON.png | 149.62 KB | Aamir M |
| #5 | After patch ON.png | 60.04 KB | Aamir M |
| #5 | Before patch ON.png | 66.45 KB | Aamir M |
| #3 | override_node_options.2.x-dev.rector.patch | 4.48 KB | project update bot |
| #3 | interdiff-last-bot.6659437.txt | 669 bytes | project update bot |
Issue fork override_node_options-3297795
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
Aamir M commentedComment #5
Aamir M commentedVerified patch #3 on Drupal 9.4.x, 10.0.x and 10.1.x. Patch applied successfully and looks good to me.
The module can be installed after applying the patch.
But I found 4 errors in the code while checking deprecated code
Screenshots are attached for reference:
Comment #6
kristen polThanks for reviewing. Moving to needs work based on #5. I do know the bot will be run again soon but I think only to update the issue summary.
Note there is another Drupal 10 compatibility issue here:
#3269901: Drupal 10 compatibility
I did not check if there was overlap between these two issues so that should be done. If they are doing the same work, one should be closed out in favor of the other... ideally, keeping this issue.
Once the patch is ready, the module will need to be tested on Drupal 10. See the following for general instructions:
https://www.drupal.org/community-initiatives/contribution-events-initiat...
Comment #7
awset commentedhi @Kristen Pol
recently this issue is discovered at https://www.drupal.org/project/override_node_options/issues/3269901#comm...
since there is a pull request made in there and this issue is a quick fix, I commit the fix there
I hope it is ok.
Thanks.
Comment #8
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #9
kristen polMoving to needs review given the work has been done in #3269901: Drupal 10 compatibility. Ideally, the MR there can be tested on Drupal 10 for the module's functionality.
Also, I haven't compared the patch here against the MR in #3269901: Drupal 10 compatibility to see if everything here is covered there, so that needs to be done.
Comment #10
kristen polWorking during porting day.
This still needs review and comparison against related issue noted in #9.
Comment #11
kristen polAdding tag for visibility.
Comment #12
kristen polThis issue still needs a review to compare against the changes in #3269901: Drupal 10 compatibility to see if this issue is still relevant or we can just use that MR.
Comment #14
jcnventuraNow that #3269901: Drupal 10 compatibility has been committed, and released as 8.x-2.7, this is clearly a duplicate.