Automated Drupal 10 compatibility fixes [#3297168]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#10	3297168.patch	77.23 KB	mkalkbrenner
#2	facets.2.0.x-dev.rector.patch	52.5 KB	project update bot

Issue fork facets-3297168

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3297168-automated-drupal-10 changes, plain diff MR !91
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

18 July 2022 at 15:35

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 18 July 2022 at 15:35

Status:

Active

» Needs review

Status	File	Size
new	facets.2.0.x-dev.rector.patch	52.5 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #3

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 16 August 2022 at 22:07

Issue summary:	View changes
Status:	Needs review	» Active

Thanks to the maintainers for the Drupal 10 compatible release!

https://www.drupal.org/project/facets/releases/2.0.5

Moving to Active so the bot can still post patches but the community will know this issue doesn't need any review or testing.

Comment #4

22 August 2022 at 07:32

balintpekker made their first commit to this issue’s fork.

Comment #5

23 August 2022 at 10:30

balintpekker opened merge request !91

Comment #6

balintpekker

he/him

Hungarian

Budapest, Hungary

commented 24 August 2022 at 08:25

Assigned:

Unassigned

» balintpekker

Comment #7

balintpekker

he/him

Hungarian

Budapest, Hungary

commented 29 August 2022 at 15:09

Assigned:	balintpekker	» Unassigned
Status:	Active	» Needs review

Dependant on jQuery UI Slider, jQuery UI TouchPunch and jQuery UI. Until these are D10 ready, tests will fail for Drupal 10.

Comment #8

project update bot commented 14 October 2022 at 22:20

Issue summary:

View changes

Comment #9

4 November 2022 at 14:58

mkalkbrenner made their first commit to this issue’s fork.

Comment #10

mkalkbrenner

German

🇩🇪

commented 7 November 2022 at 11:25

Issue summary:

View changes

Status	File	Size
new	3297168.patch	77.23 KB

There still seem to be issues on gitlab. Uploading a patch ...

Comment #11

7 November 2022 at 19:56

mkalkbrenner committed 79d7763 on 2.0.x

Issue #3297168 by mkalkbrenner, balintpekker: Automated Drupal 10...

Comment #12

7 November 2022 at 21:34

mkalkbrenner committed 747da6e on 3.0.x

Issue #3297168 by mkalkbrenner, balintpekker: Automated Drupal 10...

Comment #13

damienmckenna

TN, USA

commented 10 November 2022 at 18:31

Given that the patches were committed is this issue done? Or is there something else that needs to be finished up?

Comment #14

mkalkbrenner

German

🇩🇪

commented 10 November 2022 at 18:35

As you can see, the tests are still failing on Drupal 10. So we can't be sure.

Comment #15

mkalkbrenner

German

🇩🇪

commented 10 November 2022 at 18:36

https://www.drupal.org/pift-ci-job/2517136

Comment #16

mkalkbrenner

German

🇩🇪

commented 10 November 2022 at 18:37

Any help to get 2.0.x tested successfully on D10 is really appreciated. I assume you need to start solving the dependency issues.

Comment #17

berdir

German

Switzerland

commented 10 November 2022 at 21:01

Anything jquery_ui related is blocked on #3277748: Drupal 10 compatibility which seems to be close, the specific modules should then be fairly straight-forward.

Comment #18

mkalkbrenner

German

🇩🇪

commented 17 November 2022 at 07:27

We still have an issue with JQuery UI Slider which doesn't support D10 yet.

Comment #19

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 18 November 2022 at 06:55

Issue tags:

+Drupal 10 porting day

Working during porting day.

#3277748: Drupal 10 compatibility is fixed now but JQuery UI Slider still isn't D10 compatible.

Comment #20

nick hope commented 13 December 2022 at 05:44

We now have release 2.0.0 of jQuery UI Slider with D10 compatiblity. The major version will need increasing from 1 to 2 in the facets composer.json file.

Comment #21

mkalkbrenner

German

🇩🇪

commented 13 December 2022 at 11:27

Thanks, I updated the dependencies. Now we have running tests!
Unfortunately the tests for 2.0x and 3.0.x both fail on D10. So there's work. Any help is welcome!

Comment #22

berdir

German

Switzerland

commented 13 December 2022 at 21:28

Status:

Needs review

» Needs work

I'm kinda confused about the status here. I think all the current patches and merge requests are outdated and have been committed?

For others looking for the test fails: https://www.drupal.org/pift-ci-job/2544039

Personally, I find the "keep the automated bot issue open" approach confusing as everywhere else, we are not doing multiple commits in the same issue and I think it's also very unlikely at this point that the bot is going to fix anything else. I'd suggest closing this as fixed and opening a new issue to fix the tests.

That said, if someone wants to start doing that: There are at least two fairly easy things, at least one test is using classy, switch to starterkit_base, that works in 90%+ of the cases and is what core did as well. And a unit test is failing because it tries to fetch a non-scalar value from the request object, which is no longer possible with that method. I have a feeling that a lot of the other weird test fails might be the same problem.