Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#9 Screenshot from 2022-08-08 13-27-52.png179.73 KBsharayurajput
#2 boldy.2.x-dev.rector.patch2.05 KBproject update bot

Issue fork boldy-3296666

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new boldy.2.x-dev.rector.patch2.05 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.

Currently Drupal Rector, version 0.13.0, cannot fix all Drupal 10 compatibility problems.

This patch does not update the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0

  • the_g_bomb committed f5b9b0a on 8.x-2.x 
    Issue #3296666 by Project Update Bot: Drupal 10 compatibility fixes.
sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput
Issue summary: View changes

I will review this patch

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Needs work

This module seems compatible for drupal 10 when we see its code
But when we try to enable this module its not visible in the extend tab
so moving status to needs work

the_g_bomb’s picture

the_g_bomb commented
Status: Needs work » Needs review

Thanks for checking. Please try again, but realise this is a theme. It can be enabled and set as default at: /admin/appearance
or by using the following drush commands:

drush theme:enable boldy
drush config:set system.theme default boldy
sharayurajput’s picture

sharayurajput commented

Ok @the_g_bomb I will try it

sharayurajput’s picture

sharayurajput commented
Assigned: Unassigned » sharayurajput
sharayurajput’s picture

sharayurajput commented
StatusFileSize
new Screenshot from 2022-08-08 13-27-52.png179.73 KB

Yes This theme is compatible with drupal 10 and working properly also provided screenshot LGTM

sharayurajput’s picture

sharayurajput commented
Assigned: sharayurajput » Unassigned
Status: Needs review » Reviewed & tested by the community

So moving status to RTBC

the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Needs work

Moving back to an open status so that new patches will be posted periodically if new deprecation fixes are needed.

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari’s picture

shivam_tiwari commented
Status: Needs work » Needs review

Theme is already compatible with D10. I checked with branch 8.x-2.x with upgrade status. Please check and let me know if any issue.

Bushra Shaikh’s picture

Bushra Shaikh commented
Assigned: Unassigned » Bushra Shaikh
Bushra Shaikh’s picture

Bushra Shaikh commented
Assigned: Bushra Shaikh » Unassigned

Verified patch #2 on Drupal 9.4.x and Checked using Upgrade Status.
I found 1 error in the code while checking deprecated code

------ ----------------------------------------------------------------
  Line   boldy.theme
 ------ ----------------------------------------------------------------
  81     Unary operation "+" on Drupal\Component\Render\MarkupInterface
         results in an error.
 ------ ----------------------------------------------------------------


 [ERROR] Found 1 error

  • 34f14834 committed on 8.x-2.x 
    Issue #3296666 Fix typo introduced in #3170052.
the_g_bomb’s picture

the_g_bomb commented
Status: Needs review » Reviewed & tested by the community

Thanks for highlighting Bushra Shaikh. I have fixed the typo.

The patch provided by drupal rector has been merged to the 8.x-2.x branch.

No more testing is required on this ticket until Drupal Rector provides more updates.

This ticker is remaining open to allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

the_g_bomb’s picture

the_g_bomb commented

I have created a new release tag which will mean composer will install the latest D10 supported verison now with all the changes made here.

No more testing is required on this ticket until Drupal Rector provides more updates.

This ticket will remaining open to allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

the_g_bomb’s picture

the_g_bomb commented
Status: Reviewed & tested by the community » Fixed

Not sure there will be any more Update Bot additions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.