Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

Status: Active » Needs review
StatusFileSize
new1.34 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.9
  2. palantirnet/drupal-rector: 0.12.0
project update bot’s picture

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 1.1.24
  2. palantirnet/drupal-rector: 0.13.0
anybody’s picture

Issue summary: View changes

Any active maintainer planning to fix this?

project update bot’s picture

danlew’s picture

Issue summary: View changes

What's left to do here to get a D10 compatible release out?

rahul17’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new10.63 KB
new56.18 KB

I have tested patch #3 on Drupal 9.5.7 and 10.0.3 and PHP 8.1. Patch applied cleanly, functionality is working as expected and making this module D10 compatible. Checked with upgrade status, no issue found.
So, moving this to RTBC.

tadas.rimkus made their first commit to this issue’s fork.

solimanharkas’s picture

I have tested patch #3 and it is also working fine with me!

tamerzg’s picture

Status: Reviewed & tested by the community » Needs work

There is actually an issue when using Ajax on Views.

This is the error:

TypeError: $wrapper.removeOnce is not a function

Its probably due to jquery once change in D10:
https://www.drupal.org/node/3158256

anybody’s picture

Priority: Normal » Major

Drupal 9 EOL is close and Drupal 10.1 is out. Any plans to fix this? Or perhaps look for new maintainers?

rahul17’s picture

StatusFileSize
new2.78 KB
new1.02 KB

Created patch to resolve "TypeError: $wrapper.removeOnce is not a function" issue.

Kindly review.

rahul17’s picture

Status: Needs work » Needs review
Bushra Shaikh’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new26.37 KB
new22.87 KB
new29.35 KB

I have reviewed and checked patch#14 this works for Drupal 9.5 and Drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 have been attached for reference:

Can be move to RTBC+1

i-trokhanenko’s picture

Status: Reviewed & tested by the community » Needs work

The patches and MRs attached above apply smoothly, but unfortunately don't work as expected, @Bushra Shaikh have you tested some of them?

Issues I found:

  • sometimes the pager disappears after clicking the "Load More" button.
  • in a recent Drupal release, the AjaxCommand viewsScrollTop was renamed to scrollTop, so, we should replace the viewsScrollTop with scrollTop in the VLMEventSubscriber.php
i-trokhanenko’s picture

Status: Needs work » Needs review
StatusFileSize
new4.25 KB

I've fixed the issues I mentioned in #17 and created a new patch, please QA.

t_d_d’s picture

StatusFileSize
new5.18 KB

Applying #18 to my usecase, I found 2 bugs:

Ajax returned twice but one result had empty data. Regardless, module's JS ran twice leading to all kind of strange behavior.

It was caused by response having 2 different "insert" commands ("replaceWith" and "prepend" (probably something unique to my usecase)) and module was not checking whether the command it is altering is really "replaceWith" one, despite comment in code noticing the possibility there might be other "insert" commands.

"Load more" button was staying even though there were no more results.

It was caused by setting text for when there are no more results empty (valid option in pager settings in views). In such case, pager template does not render anything and as a result, pager is missing in new content. So far it is valid behavior, but then JS, not finding pager in new content, left old one intact.

Attached patch adds fixes to these problems on top of #18. Module now only acts upon "replaceWith" "insert" command and when text for no more results is missing, it removes the pager entirely when there are no more results.

ayush9598 made their first commit to this issue’s fork.

  • i-trokhanenko committed 4f704b58 on 2.x
    Issue #3290508 by t_d_d: Automated Drupal 10 compatibility fixes
    
i-trokhanenko’s picture

Status: Needs review » Fixed

Committed the #19 patch. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.