Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 10.
To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects
Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.
The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.
If the issue is reopened, then new automated patches will be posted.
If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Providing feedback
If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | telephone_international_widget.2.0.x-dev.rector.patch | 485 bytes | project update bot |
| #18 | interdiff-last-bot.6664234.txt | 817 bytes | project update bot |
| #5 | After patch TI (1).png | 75.06 KB | Aamir M |
| #5 | Before patch TI (1).png | 67.39 KB | Aamir M |
| #5 | Patch TI.png | 128.32 KB | Aamir M |
Issue fork telephone_international_widget-3289978
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.12.0, cannot fix all Drupal 10 compatibility problems.
This patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #3
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
Aamir M commentedComment #5
Aamir M commentedVerified patch #3 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.
Testing Steps:
1. Install drupal 10.0.x and 10.1.x version
2. Install the Telephone International Widget module (8.x-1.x) version and save it in the Module folder
(https://www.drupal.org/node/3063736/git-instructions/8.x-1.x/nonmaintainer)
3. Open drupal 10 or 10.1 and click on Extend
4. Check the Telephone International Widget module which unable to install
5. Now apply the patch [Where the Telephone International Widget module was saved i.e Module folder]
6. Reload the page and again check the Telephone International Widget module (Note: Clear all caches if required)
7. Now this module is enabled and also install successfully
The module can be installed after applying the patch.
Can be moved to RTBC
RTBC+1
Comment #6
jaydev bhatt commentedI have Review this patch and works well with drupal 9.4 and drupal 10.0.1
this is good to be moved into RTBC.
During the Drupal 10 Readiness Initiative meeting, it was discussed whether or not to mark bot issues "RTBC" when humans have successfully tested them and the decision was "yes". So, moving this from to "RTBC" based on the successful testing above. If the maintainer prefers to move this back to "Active" or "Needs review", please just add a note explaining this preference so new contributors leave the issue alone.
Comment #9
jcandan commentedReported a bug to Rector about the patch discrepancies.
However, this seems ready to merge. Going forward.
Comment #11
jcandan commentedPer instructions, setting this issue back to Active to allow continued automated patches.
Comment #12
omkar-pd commented@jcandan In the commit, the
corekey is not removed so the module won't work on d10 withcorekey, And if we remove thecorekey then it will drop the support from older versions of d8..So, we should addcore_version_requirement: ^8.9 || ^9 || ^10and create a new stable release.Check comment #8 from this issue
Comment #15
jcandan commentedGood catch, @omkar-pd.
Comment #16
jcandan commentedComment #17
project update bot commentedUpdating bot issue summary.See #3313904: Update project bot templates for RTBC status support and human interaction tips
Comment #18
project update bot commentedThis is an automated patch generated by Drupal Rector. Please see the issue summary for more details.
It is important that any automated tests available are run with this patch and that you manually test this patch.
Drupal 10 Compatibility
According to the Upgrade Status module, even with this patch, this module is not yet compatible with Drupal 10.
Currently Drupal Rector, version 0.15.1, cannot fix all Drupal 10 compatibility problems.
Therefore this patch does not update the
info.ymlfile for Drupal 10 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #19
jcandan commentedAlready Drupal 10 compatible. Rector appropriately fixes the public property, and submitted a patch for it to be protected. This same fix will come along with the Drupal 11 automated ticket.
Comment #20
jcandan commented