Automated Drupal 10 compatibility fixes

Hi,
i will review this patch.

Verified patch #3 on Drupal 10 Patch applied successfully
Testing Steps:

1. Install drupal 10
2. clone the branch on drupal (8.x-2.x) latest branch on drupal 9 and checked deprecated code uisng upgrade status module
3. removed deprecated code according to upgrade status module , provide a patch #5 ,applied patch #5 and again checked deprecated code on drupal 9
4. and tried to installed module on drupal 10 and drupal 9

The module has been successfully installed, and it can be moved to RTBC+

As a reminder, if the module has automated tests, they should be run against D10 as part of the testing process. I ran the tests locally and it turned up multiple errors:

Drupal\Tests\login_destination\Functional\InstallTest::testInstallation
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to use.

  1x: The Drupal\Tests\login_destination\Functional\InstallTest::$modules property must be declared protected. See https://www.drupal.org/node/2909426
    1x in DrupalListener::startTest from Drupal\Tests\Listeners

TypeError: PHPUnit\Framework\Assert::assertNotContains(): Argument #2 ($haystack) must be of type iterable, string given, called in /var/www/web/modules/contrib/login_destination/tests/src/Functional/UrlParameterTest.php on line 36

The attached patch addresses those issues, and I'll trigger the test run to demonstrate passing tests (note that the test suite includes an integration test with admin_toolbar, so that module needs to be present if testing locally).

Automated tests on drupal.org are failing because the require-dev version of admin_toolbar is set to 1.23, while that module's D10 compatible version is 3.x.

The attached patch adds the correct composer version requirement, but is otherwise identical to #6.

Some additional fixes. I chose classy as the default theme base on this explanation but maybe there is a better choice.

I have reviewed and checked Patch #11 this works for drupal 9.5 and drupal 10.0. and 10.0.1
Screenshots of the compatibility on 9.5 and Config along with the Setting page on 10 have been attached for reference:

Thanks for maintaining this nice and functional module.

Hoping for a soft commit on the 8.x-2.x branch, and a soft tag release.
Testing now with git clone git@git.drupal.org:project/login_destination.git

Had Real physical testing round for Login Destination with Drupal ~10

composer create-project drupal/recommended-project:~10 /var/www/html/sandboxes/drupal10login_destination__test
cd /var/www/html/sandboxes/drupal10login_destination__test/
composer require drush/drush:~11.0;

cd /var/www/html/sandboxes/drupal10login_destination__test/web/modules
git clone git@git.drupal.org:project/login_destination.git
cd login_destination/
git fetch origin
git checkout 8.x-2.x

Get the patch and apply it under Drupal 10 site. ( to be able to enable )

wget https://www.drupal.org/files/issues/2022-11-28/login_destination-3288368-11.patch
git apply login_destination-3288368-11.patch
rm login_destination-3288368-11.patch

Change file/directory mod and ownership of files:

cd /var/www/html/sandboxes/drupal10login_destination__test/
sudo chmod 775 -R .;sudo chown www-data:$USER -R .;

Install with Drush

./vendor/drush/drush/drush site:install standard --yes --site-name="Login Destination - Real physical testing with Drupal ~10" --account-name="webmaster" --account-pass="d" --account-mail="test@drupal.org" --db-url="mysql://root:123___@localhost/sandboxes_drupal10login_destination__test" -vvv ;
./vendor/drush/drush/drush pm:enable login_destination

[success] Successfully enabled: login_destination

Rebuild the cache:

sudo chmod 775 -R .;sudo chown www-data:$USER -R .;
./vendor/drush/drush/drush cache:rebuild

Open a browser and change the address to:
http://localhost/sandboxes/drupal10login_destination__test/web/

On navigating to "/admin/config/people/login-destination"

And configuring a Dashboard page for directing all logged in users to a dashboard

And a Good Bay page for redirecting after logging out to a good bay message page

When a Test Content Editor login to the site

Then the user will be directed to the Dashboard page

And when a user loges out
Then the user will be directed to the Good Bay page

Tested the #11 patch. Thank you Pierre.
It is working for the basic used scenarios.

Thanks for maintaining this nice and functional module.

Hoping for a soft commit on the 8.x-2.x branch, and a soft tag release.
Testing now with git clone git@git.drupal.org:project/login_destination.git
and git apply for the patch

Created an issue fork and committed patch #11
Thanks, Pierre.

git clone git@git.drupal.org:issue/login_destination-3288368.git
cd login_destination-3288368/
git checkout 3288368-8-x-2-x
wget https://www.drupal.org/files/issues/2022-11-28/login_destination-3288368-11.patch
git apply login_destination-3288368-11.patch
rm login_destination-3288368-11.patch
git add .
git commit -m 'Issue #3288368: Automated Drupal 10 compatibility fixes' --author="Project Update Bot <git@users.noreply.drupalcode.org>"
git push origin 3288368-8-x-2-x

Seconding the RTBC, above, and the priority for getting a new release for this widely-used module.

Tested with the #11 patch. Good to release.