Automated Drupal 10 compatibility fixes [#3286226]

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.

Comment	File	Size	Author
#18	betterlogin-d10-compatibility-3286226-18-1.patch	1.62 KB	yogeshsevak
#18	betterlogin-d10-compatibility-3286226-18.patch	1.54 KB	yogeshsevak
#5	Login-Drupal-Test.png	37.5 KB	dishakatariya
#5	afterpatch.png	66.53 KB	dishakatariya
#5	before patch.png	74.54 KB	dishakatariya
#3	betterlogin.1.x-dev.rector.patch	1.54 KB	project update bot
#3	interdiff-last-bot.6641746.txt	692 bytes	project update bot
#2	betterlogin.1.x-dev.rector.patch	1.17 KB	project update bot

Issue fork betterlogin-3286226

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3286226-automated-drupal-10 changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

15 June 2022 at 18:11

Project Update Bot created an issue. See original summary.

Comment #2

project update bot commented 15 June 2022 at 18:11

Status:

Active

» Needs review

Status	File	Size
new	betterlogin.1.x-dev.rector.patch	1.17 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #127

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.9
palantirnet/drupal-rector: 0.12.0

Comment #3

project update bot commented 22 July 2022 at 18:37

Status	File	Size
new	interdiff-last-bot.6641746.txt	692 bytes
new	betterlogin.1.x-dev.rector.patch	1.54 KB

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

Drupal 10 Compatibility

According to the Upgrade Status module this patch makes this module compatible with Drupal 10! 🎉
This patch updates the info.yml file for Drupal 10 compatibility.

Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 10 compatibility fixes as they become available in Drupal Rector.

Debug info

Bot run #139

This patch was created using these packages:

mglaman/phpstan-drupal: 1.1.24
palantirnet/drupal-rector: 0.13.0

Comment #4

dishakatariya commented 24 August 2022 at 13:17

Assigned:	Unassigned	» dishakatariya
Issue summary:	View changes

Comment #5

dishakatariya commented 24 August 2022 at 13:22

Assigned:

dishakatariya

» Unassigned

Status	File	Size
new	before patch.png	74.54 KB
new	afterpatch.png	66.53 KB
new	Login-Drupal-Test.png	37.5 KB

Verified patch #3 on Drupal 10.0.x and 10.1.x. Patch applied successfully and looks good to me.

Testing Steps:

1. Install drupal 10.0.x and 10.1.x version
2. Install the Better Login module (8.x-1.x-dev) version and save it in the Module folder
(git clone --branch '8.x-1.x' https://git.drupalcode.org/project/betterlogin.git)
3. Open drupal 10 or 10.1 and click on Extend
4. Check the Better Login module which unable to install
5. Now apply the patch [Where the Better Login module was saved i.e Module folder]
6. Reload the page and again check the Better Login module (Note: Clear all caches if required)
7. Now this module is enabled and also install successfully

The module can be installed after applying the patch and also work properly (For reference see attached Screenshots)
Can be moved to RTBC
RTBC+1

Comment #6

project update bot commented 14 October 2022 at 20:41

Issue summary:

View changes

Comment #7

rajab natshah

he/him

commented 8 January 2023 at 11:26

Priority:	Normal	» Major
Issue summary:	View changes

Comment #8

rajab natshah

he/him

commented 19 January 2023 at 07:29

Thank you, Yogesh for having time to maintain this Better UI/UX login module.
Hoping for a soft commit. To ease testing with Drupal 10. and a soft tag release
Testing now with git clone --branch '8.x-1.x' https://git.drupalcode.org/project/betterlogin.git
and applying the patch.

Comment #9

rajab natshah

he/him

commented 24 January 2023 at 08:02

Priority:

Major

» Critical

Comment #10

rajab natshah

he/him

commented 2 February 2023 at 09:47

Comment #11

rajab natshah

he/him

commented 8 February 2023 at 07:36

Comment #12

mgstables

Dutch

commented 15 April 2023 at 07:27

I can confirm, Patch #3 works well.

Drupal 10.0.7
PHP 8.1.6

Comment #13

9 May 2023 at 16:23

Abdalhamid made their first commit to this issue’s fork.

Comment #14

Abdalhamid commented 9 May 2023 at 16:48

When trying to update a Drupal 9 website to 10 , composer needs first to install the module and then apply the patch, but the module can't be installed because it's not compatible with Drupal 10, so I created a fork to download the module from until we have the new release.

Comment #15

9 May 2023 at 16:49

Abdalhamid opened merge request !1

Comment #16

devil2005 commented 10 May 2023 at 06:35

Hello,

Can we have a D10 compatible release please ?

Thanks a lot

Comment #17

devil2005 commented 10 May 2023 at 13:07

@Abdalhamid : can't update to D10 even with your branch :

 Problem 1
    - drupal/betterlogin 1.2.0 requires drupal/core ~8.0 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev] but it conflicts with your root composer.json require (^10).
    - drupal/betterlogin[1.3.0, ..., 1.x-dev] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (^10).
    - Root composer.json requires drupal/betterlogin ^1.2.0 -> satisfiable by drupal/betterlogin[1.2.0, ..., 1.x-dev].

Thanks

Comment #18

yogeshsevak commented 11 May 2023 at 19:00

Status	File	Size
new	betterlogin-d10-compatibility-3286226-18.patch	1.54 KB
new	betterlogin-d10-compatibility-3286226-18-1.patch	1.62 KB

Providing updated patches.
For 8.x-1.6 : betterlogin-d10-compatibility-3286226-18-1.patch
For 8.x-1.x-dev : betterlogin-d10-compatibility-3286226-18.patch

Please review.

Comment #19

devil2005 commented 12 May 2023 at 05:47

still can't up after applied patch

  Problem 1
     - Root composer.json requires drupal/betterlogin ^1.6 -> satisfiable by drupal/betterlogin[1.6.0, 1.x-dev].
    - drupal/betterlogin[1.6.0, ..., 1.x-dev] require drupal/core ^8 || ^9 -> found drupal/core[8.0.0-beta6, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] but it conflicts with your root composer.json require (^10).


Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

i'm using 1.6 and applied just patch for 1.6

Comment #20

devil2005 commented 14 June 2023 at 06:57

Hi,

Anybody can help please ?

Thanks :-)

Comment #21

rajab natshah

he/him

commented 22 June 2023 at 07:44

Status:

Needs review

» Reviewed & tested by the community

Hopping for a commit and a tag release.

Comment #22

rajab natshah

he/him

commented 22 June 2023 at 08:21

Facilitate a seamless upgrade process while maintaining compatibility with both Drupal 9 and Drupal 10 using a unified code base.

Only for testing:
Having the issue fork in the composer.json file.
In the repositories

  "repositories": {
    "drupal": {
      "type": "composer",
      "url": "https://packages.drupal.org/8",
      "exclude": [
        "drupal/betterlogin"
      ]
    },
    "drupal/betterlogin": {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/betterlogin-3286226.git"
    }
  },

and in require

  "require": {
    "drupal/core": "~10.0",
    "drupal/betterlogin": "dev-3286226-automated-drupal-10 as 1.6.0"
  },

Comment #23

rajab natshah

he/him

commented 22 June 2023 at 08:41

Have the composer.json file back which was added by AbedAlhamid Ahmad to let the issue fork work with composer, but with Drupal 9 and Drupal 10 support.

The composer.json file will not be needed when merged to the 8.x-1.x branch.
I'm ok with having it tho.

Comment #24

23 June 2023 at 05:36

Vishal Choudhary made their first commit to this issue’s fork.

Comment #25

vishal choudhary

Dharmshala

commented 23 June 2023 at 06:00

Comment #26

devil2005 commented 28 June 2023 at 12:35

Hi,

Will you release a stable version of the module on d10? to up my websites with mass update :)

Thanks

Comment #27

seanb

Dutch

Netherlands

commented 18 July 2023 at 23:11

Status:

Reviewed & tested by the community

» Needs work

The commit added in #25 adds better_login_form_config.module and better_login_form_config.info.yml. I think those are for the better_login_form_config module?

I'm going to revert this commit.

Comment #28

devil2005 commented 19 July 2023 at 05:55

Hi,

Yeah but composer doesn't find the new version on the repo... so i have to update manually.

Thanks

Comment #29

morepolarbears commented 21 August 2023 at 09:21

Hi all,

Thanks a lot for your work.

I can confirm the current version of the fork (https://git.drupalcode.org/issue/betterlogin-3286226/-/tree/3286226-auto...) works on my Drupal 10.1.2 test install.

What's needed to go forward with the release of the updated package?

Comment #30

rajab natshah

he/him

commented 19 September 2023 at 09:02

Hoping for a commit and a release.
To have a smooth upgrade process for projects.

Comment #31

deaconblues commented 29 September 2023 at 02:10

Hi everyone,

Just wanted to check in to see what the status is for the D10 release of the module. The code changes listed in morepolarbears's comment works great on my D10 site. What needs to happen to get a release of this code?

Thanks in advance!

Comment #32

adam-vessey commented 29 September 2023 at 15:23

I gave a look at this in a ddev D10 env, and it indeed installed (after adding the repository entry and requiring the module accordingly); however, I found that there may be some styling updates desirable? As in: It seems like the flat 20% width in the CSS (https://git.drupalcode.org/project/betterlogin/-/blob/dfdd367b3f3937a01b...) causes overflow issues, with the username/password/etc fields being partially hidden with the default configuration.

That said, further examined our internal environment and found that we weren't actually using this module despite having it installed and enabled as gin_login was taking precedence; so in our instance, moving to remove betterlogin from our environment.

Comment #33

rajab natshah

he/him

commented 8 October 2023 at 09:16

Seems that no release for this module.
Used it for quite long time.
This is a blocker for upgrading to Drupal 10
Please, help us to have a smoother upgrade way
Only by committing and a tag release.

Comment #34

rajab natshah

he/him

commented 9 October 2023 at 13:33

This is a direct fork for the Better Login module
https://packagist.org/packages/vardot/betterlogin
https://github.com/Vardot/betterlogin

Following with changes from
#3286226: Automated Drupal 10 compatibility fixes
Started this Fork module on the 2.0.x branch
Switching to use the forked version

Dropped the use of this module in all new projects.
Hoping for a new branch 2.0.x.
Only help having a smooth upgrade process for old projects