Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 May 2022 at 07:27 UTC
Updated:
15 Jun 2022 at 22:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
libbna commented@leslieg, like Reset button or clear all button?
Comment #3
leslieg commented"Reset to default" seems to make the most sense. Maybe get UX opinion.
Comment #4
chrisfromredfinI think we have "Clear filters" which I think resets to literally every module. I would like a way to reset back to the "Default" set, which has replaced the "Recommended" tab in the UI.
I'm split on whether "Reset to default" is the right language or "Recommended filters" or something with the word "Recommended" is more appropriate. I would love to hear from anyone with UX experience ex.g. Jillian, Divya, Sascha, et al.
Comment #5
hooroomooComment #7
hooroomooMy proposal is to use "Reset to recommended modules" because there could be confusion with what "default" actually means and the potential confusion between "clear filters" and "default filters". Also I feel like "recommended modules" makes it clearer that the modules are the things that are being recommended vs. the filters.
The MR makes it so the "Reset to recommended modules" only appears when none of the filters are applied or if the user clicked "Clear filters" so they are not confused with each other and doesn't make the area look too busy.
Open to feedback/changing it of course :)
Comment #8
hooroomooComment #9
hooroomooComment #10
chrisfromredfinThe functionality is all there, I personally don't like how you only see it if you've cleared completely. I feel like at any point I should be able to "clear" or, essentially "start over" (which recommended filters). I wonder if we kept the words short like "Recommended filters" and kept it next to "Clear filters" all the time.
I'll try and bring some UI/UX attention to this tomorrow in the meeting.
Comment #11
fjgarlin commentedAdded some feedback in the MR.
Comment #13
chrisfromredfinGreat work on the functionality I think it's a bit of an improvement.
I would also like to see a little bit more space between the two link options.
Maybe something like
We also need to decide how we're getting around the linter with href's being #0 or #, in terms of accessibility, the linter, etc. Links that go nowhere are bad for a11y, no? Should those be something else? They seem to make sense visually as links...
Comment #14
hooroomoore: #13
So I changed the a tags for 'Clear filters' and 'Recommended filters' to be buttons that are styled to look like links if that works. That way we avoid dealing with hrefs and potential accessibility problems. My thought was that it's ok for it to be a button since it does perform an action.
Comment #15
hooroomooComment #16
chrisfromredfinI think this is a good incremental improvement. This may change re: UI changes currently being discussed in https://www.drupal.org/project/project_browser/issues/3281218 but if anything that issue might actually remove the 'clear filters' and not this one, so I think get this one in.
Comment #19
tim.plunkettMerged! Thanks