Problem/Motivation

There is no way to return to the "default" filters once you change filters

Steps to reproduce

Proposed resolution

Remaining tasks

  • ✅ File an issue about this project
  • ☐ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release

User interface changes

API changes

Data model changes

Release notes snippet

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

leslieg created an issue. See original summary.

libbna’s picture

@leslieg, like Reset button or clear all button?

leslieg’s picture

"Reset to default" seems to make the most sense. Maybe get UX opinion.

chrisfromredfin’s picture

I think we have "Clear filters" which I think resets to literally every module. I would like a way to reset back to the "Default" set, which has replaced the "Recommended" tab in the UI.

I'm split on whether "Reset to default" is the right language or "Recommended filters" or something with the word "Recommended" is more appropriate. I would love to hear from anyone with UX experience ex.g. Jillian, Divya, Sascha, et al.

hooroomoo’s picture

Assigned: Unassigned » hooroomoo

hooroomoo’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new46.12 KB
new26.53 KB

My proposal is to use "Reset to recommended modules" because there could be confusion with what "default" actually means and the potential confusion between "clear filters" and "default filters". Also I feel like "recommended modules" makes it clearer that the modules are the things that are being recommended vs. the filters.

The MR makes it so the "Reset to recommended modules" only appears when none of the filters are applied or if the user clicked "Clear filters" so they are not confused with each other and doesn't make the area look too busy.

Open to feedback/changing it of course :)

hooroomoo’s picture

hooroomoo’s picture

Assigned: hooroomoo » Unassigned
chrisfromredfin’s picture

The functionality is all there, I personally don't like how you only see it if you've cleared completely. I feel like at any point I should be able to "clear" or, essentially "start over" (which recommended filters). I wonder if we kept the words short like "Recommended filters" and kept it next to "Clear filters" all the time.

I'll try and bring some UI/UX attention to this tomorrow in the meeting.

fjgarlin’s picture

Status: Needs review » Needs work

Added some feedback in the MR.

srishtiiee made their first commit to this issue’s fork.

chrisfromredfin’s picture

Great work on the functionality I think it's a bit of an improvement.

I would also like to see a little bit more space between the two link options.
Maybe something like

.filters-applied a { padding: 0 0.25rem; }

We also need to decide how we're getting around the linter with href's being #0 or #, in terms of accessibility, the linter, etc. Links that go nowhere are bad for a11y, no? Should those be something else? They seem to make sense visually as links...

hooroomoo’s picture

re: #13
So I changed the a tags for 'Clear filters' and 'Recommended filters' to be buttons that are styled to look like links if that works. That way we avoid dealing with hrefs and potential accessibility problems. My thought was that it's ok for it to be a button since it does perform an action.

hooroomoo’s picture

Status: Needs work » Needs review
chrisfromredfin’s picture

Status: Needs review » Reviewed & tested by the community

I think this is a good incremental improvement. This may change re: UI changes currently being discussed in https://www.drupal.org/project/project_browser/issues/3281218 but if anything that issue might actually remove the 'clear filters' and not this one, so I think get this one in.

tim.plunkett made their first commit to this issue’s fork.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Merged! Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.