Claro - April 13 2022 Meeting in Slack

This meeting takes place every Wednesday at at 3pm UTC (8:30pm IST, 4pm CET, 10am ET, 7am PST). See Time.is to see what that is in your timezone.

The meetings are held using Slack threads in the #admin-ui Slack channel.

UPDATED (transcript added)

Introductions
11 replies

katannshaw
deviantintegral
ckrina
andy-blum
lauriii
rkoller
thejimbirch
pauline
mherchel
cindytwilliams
saschaeggi

***

Claro general status update
➤ The goal is to have Claro as the default admin theme for D10, deprecating Seven.
➤ Beta requirements need to be ready by mid-May, so we should get rid of the remaining Claro stable blockers before that so we have time to finish the needed steps to deprecate Seven.

***

What agenda items would you like to discuss today?
5 replies

ckrina
Review [META] Assess Claro for WCAG colour contrast AA conformance to discuss which of those issues should become stable blockers

andy-blum
Do we have a hard deadline yet? Something more concrete than "ready by before mid-may"?

ckrina
@andy-blum I don’t think so, and I’m not sure we’ll get something more specific

ckrina
@katannshaw on last item https://www.drupal.org/project/drupal/issues/3272614
The buttons in Views setting modals become ghost buttons and change weight on focus

ckrina
Sorry I forgot it to re-mention it here

***

Any further general updates from the maintainers or product managers?
6 replies

ckrina
We got several issues RTBC and committed this past days, thanks everybody involved!

ckrina
Right now there are only 2 missing stable blockers :tada:

ckrina
@andy-blum is asking:
> so we have time to finish the needed steps to deprecate Seven.
Any ideas how long this part will take?

ckrina
(moving this here to clean-up that one to post new discussions)

ckrina
No idea how long it’ll take. We need design decisions in one issue (https://www.drupal.org/project/drupal/issues/3167349) and finish the Install page
Redesign Settings Tray

ckrina
In theory nothing else should block us apart from that (edited)

***

Where can contributors help this week?
12 replies

katannshaw
Note: If you want your item added to a new topic thread, add a thread icon :thread: with it

lauriii
Needs some JavaScript work: https://www.drupal.org/project/drupal/issues/3081489
Remove duplicate code from veritcal-tabs.js in Claro

lauriii
I can help onboarding with that issue in case anyone is interested in working on that

lauriii
Needs some more work https://www.drupal.org/project/drupal/issues/3271305 but the changes should be relatively straight forward

ckrina
Review Define Blue scale for Claro, that would help a lot defining blue colors https://www.drupal.org/project/drupal/issues/3251709

ckrina
Also “Create smaller variations for form elements”: this one needs someone reviewing the last changes and check if it still needs things to be fixed or can be moved to Needs review. https://www.drupal.org/project/drupal/issues/3083256

katannshaw
Let me know if you want any of these added as topics

ckrina
Not for the ones I’ve added :slightly_smiling_face:

ckrina
Also, this one needs a reroll to 9.4.x: https://www.drupal.org/project/drupal/issues/3214332
Preview content is broken in Claro.

ckrina
More Needs work issues:
* Claro’s preprocessing of field multiple value form’s table header cell removes potential changes by others: Needs issue summary updates and steps to test: https://www.drupal.org/project/drupal/issues/3099026
* Fix Claro styles for exposed views filters wrapped in fieldsets: https://www.drupal.org/project/drupal/issues/3133639
* Update Placeholder styles so that contrast ratio passes guidelines https://www.drupal.org/project/drupal/issues/3020418
* Links on dark backgrounds have a green and a white focus outline: https://www.drupal.org/project/drupal/issues/3266825

ckrina
And issues that Need review:
* Clean up Claro’s unused images: https://www.drupal.org/project/drupal/issues/3092984
* Contextual Links Style Update: https://www.drupal.org/project/drupal/issues/3023322
* CKEditor + HTML filter UX broken on Claro: https://www.drupal.org/project/drupal/issues/3216214
* Dropbutton item button height does not match toggle: (not sure id this issue should be Claro’s or Paragraphs’ https://www.drupal.org/project/drupal/issues/3274617

thejimbirch
Asked a coworker to review Define Blue scale for Claro.
Posting these Needs work and Needs review to Kanopi's contrib slack, thanks!

***

Topic 1: Review [META] Assess Claro for WCAG colour contrast AA conformance to discuss which of those issues should become stable blockers :thread: (edited)
21 replies

ckrina
The issue link is https://www.drupal.org/project/drupal/issues/3088562

ckrina
I’ve been doing some cleanup, but I’m afraid a few of them might become stable blockers.

ckrina
Like https://www.drupal.org/project/drupal/issues/3266299: I feel like this one should become stable blocker since disabled elements still need to comply with the contrast ratio 4.5:1. Meaning the existing form disabled styles should be darker

mherchel
I'm not so sure. Discussion is at https://drupal.slack.com/archives/C2ANFUGGG/p1649851821588239

lauriii
I’m 90% certain based on earlier research that it’s allowed, and it’s also desired

rkoller
i agree i also wouldnt call it a stable blocker based on the discussion i've just catched up reading mike posted in here. never the less i also agree with @Mike Mais general question in that thread why to display the information greyed out (but nothing for a stable blocker but something that should be thought about)

ckrina
I really liked @Mike Mai’s idea about using some other way to indicate something is disabled, like a lock icon or similar. I’ll wait to see other people’s thought but that could be a good follow-up once we agree on what needs to happen here.

lauriii
Ideally we could have something that would also help indicate why something is disabled

lauriii
since having something disabled without explanation is kind of a UX problem

Mike Mai
totally agree. the icon indicator would connect with the helper text

lauriii
I wouldn’t call https://www.drupal.org/project/drupal/issues/3266299 a stable blocker because presumably it falls to the incidental category in WCAG https://webaim.org/articles/contrast/#incidental

lauriii
and I think we did research earlier that it was better to have low contrast to make sure it’s distinguishable from non-disabled form elements

rkoller
about one other issue from the meta issue list. https://www.drupal.org/project/drupal/issues/3272266 i consider a bit more problematic in the context of being a possible blocker?
Grey button's background color has a too low contrast ratio against page background

ckrina
I am researching about this one too

ckrina
And I recall discussing about this when we defined the grey to use here, and that this one was complying with the contrast requirements

lauriii
I think we thought https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html would be applicable here

lauriii
it describes that the boundaries don’t have to meet the contrast requirements so long as the text meets these requirements

ckrina
yes, I think so

rkoller
yes it is about 1.4.11

rkoller
i've talked about the button issue with @Mike Gifford (CivicActions) in here https://drupal.slack.com/archives/C2ANFUGGG/p1647783436960889 (it was about 1.4.11 and interface components in general but the talk came also to the buttons) and that was his recommendation in regards of the buttons: https://drupal.slack.com/archives/C2ANFUGGG/p1648563443577639?thread_ts=...

saschaeggi:gitlab:
Alternatively we could use buttons with an outline only instead of the grey ones (like we do it in Gin). Also grey buttons can be understood as disabled buttons

***

Topic 3: [META] Assess Claro’s conformance with WCAG Text spacing, Text resize, and Reflow.
1 reply

katannshaw
https://www.drupal.org/project/drupal/issues/3087225

***

Topic 4: Assess accessibility of Claro in High Contrast AKA forced colors mode :thread:
4 replies

katannshaw
https://www.drupal.org/project/drupal/issues/3080100

lauriii
Lot’s of progress on this! Thank you everyone for your help on this :pray:

andy-blum
:point_up: working on the radio button issue

andy-blum
Ready for review! @mherchel / @lauriii
https://www.drupal.org/project/drupal/issues/3271305#comment-14480050
Claro's radio buttons and checkboxes are unusable in high-contrast / forced colors mode

***

Topic 5: The buttons in Views setting modals become ghost buttons and change weight on focus :thread:
14 replies

katannshaw
https://www.drupal.org/project/drupal/issues/3272614

ckrina
I posted some of the link should become action links

ckrina
But now I’m trying to reproduce this locally and an can’t

ckrina
@rkoller have you tried with the latest release?

ckrina
This is what I see https://monosnap.com/direct/ghaIfkL0UL6p9soLoc7Qc4ueULBDmi
Monosnap screenshot toolMonosnap screenshot tool
Screenshot "Content (Content) UMass Web Ecosystem 2022-04-13 16-39-06.png" (96 kB)
https://monosnap.com/direct/ghaIfkL0UL6p9soLoc7Qc4ueULBDmi

ckrina
which is the default gray button… is something else expected? (edited)

rkoller
i havent revisited the issue and retested since i reported it. one second.

mherchel
this one is obviously a design issue, but it shouldn't be a stable blocker as the focus state still meets contrast minimums because of the focus ring

rkoller
@ckrina it looks fine now. so something changed from back when i've reported it. even though i like your idea with the delete button: https://www.drupal.org/project/drupal/issues/3272614#comment-14477195

ckrina
yeah, +1 to the Action link. Not a fan on this huge red button there :sweat_smile:

rkoller
@ckrina so should we remove thaqt issue from the meta issue list and change the scope of the issue to changing the buttons by adding the action link for delete?

ckrina
That would be great, yes!!

rkoller
have another meeting now but i will update the issue summary of the meta and remove the issue from the list and leave a comment and then update the issue summary of the issue and update it based on your mockup and aside note that the current 9.4.x branch doesnt have the issue the issue was initial created for

rkoller
removed the issue from the meta and updated the title and IS https://www.drupal.org/project/drupal/issues/3272614
Use the Action link button style for Views setting modal buttons

***

Continue the conversation in Slack. Thank you for showing up and contributing!
If you have additional questions or comments, please post them here or on the meeting agenda issue: https://www.drupal.org/project/drupal/issues/3275062