Hide the policies until a new password is entered

Hi, I did custom code which hide password policy status thing on user edit and user register form.

hide_pwpolicy.module

<?php

/**
 * @file
 * Custom hide password policy on user edit form.
 */

use Drupal\Core\Form\FormStateInterface;

/**
 * Implements hook_form_alter().
 */
function hide_pwpolicy_form_alter(&$form, FormStateInterface $form_state, $form_id) {
  $whitelist = ['user_form', 'user_register_form'];

  if (in_array($form_id, $whitelist)) {
    $form['#after_build'][] = 'hide_pwpolicy_custom_after_build';

  }
}

function hide_pwpolicy_custom_after_build($form, &$form_state) {
  $form['account']['password_policy_status']['#access'] = FALSE;

  return $form;
}

Postponed this issue while #2849271: Decouple display of policy table and policy validation is not committed.

I'll work on this

I put a states option on the password policy to show only when the password field is not empty as you can see in the images

I'll be reviewing

Before I switched to MR, which I did:
- Installed password policy and password character length policy.
- I went to /admin/config/security/password-policy/add and created a new policy with the password character length restriction and applied it to Authenticated user
- I went to /user/[user:id]/edit and there are just the recommendations to make the password stronger
- After switching to MR, I went again to edit the user profile and it now shows the recommendations and the password policy restrictions.

I'll attach before/after screenshots to comparison.

+1 RTBC, rebased.

Assigning to myself as I'm reviewing/merging ready RTBC fixes/updates over the next few days.

I tested and this seems like a simple UX improvement so I think it's okay to add. Note that it doesn't hide it after the password is deleted but that's probably okay as well.

Related, but not part of this issue is that, when editing a user as an admin (or with certain permissions), the status and roles show up between the password fields and the table which pushes the info far below and the user might not see it. A separate issue could be opened for that.

Thanks everyone for their work on this issue.

The fix has been merged and will be part of the next release.

This was against 4.0.x as 8.x branches are no longer supported, so changing version.

This is part of the new 4.0.1 release.