[Taxonomy] Enable Gin edit form by default

I'm changing this into a feature request, as this was until now not part of Gin.
We have to think of that should be placed in the sidebar – or if we need another option to just make the form actions sticky on those forms.
So changing this back to needs work for this reason :)

I think we should definitely go for a complete integration including sidebar. We did this for thunder using hook_gin_content_form_routes(). Additionally, `relations` and `path_settings` details should be moved to the meta sidebar as well, similar to what is done at this thunder branch.

The current state of the implementation splits the route determination for sticky action buttons from isContentForm() to stickyActionButtons(). If we decide to do that we should add another layer of hook_ and hook_alter api. I would also suggest that we add hooks for adding and removing actions, is there an issue yet?

@volkerk maybe you can share a screenshot of how that looks in Thunder at the moment.

Sure

Not most elegant solution, but works for me.
I didn't add entity.taxonomy_vocabulary.add_form or entity.taxonomy_vocabulary.edit_form routes to follow same UI as content type edit forms.

The last patch only works for vocabularies named 'tags'. I created a MR based on the patch and the changes from the Thunder distribution.

I have tested the MR, But it has conflict, @DieterHolvoet can you please check and update the MR.
Thanks in Advance :)

My bad, I forgot to push my changes. Should work now.

I have tested the MR 237 applied successfully. and solution is working. i have shared the screenshot.

Before

after

Thanks

The patch #2
does not work on taxonomy translation pages. I've updated the patch to include the taxonomy translation add and edit route names.

@iheb.attia work is being done in the MR, you should test those changes instead of the patch from #2.

A couple of suggestions from reviewing the MR:

1. Should we undo moving the `langcode` field in to the sidebar? The node form doesn't do this so doing it for taxonomy terms makes them inconsistent.
2. I think we should include the `entity.taxonomy_term.content_translation_edit` route as well.

Just wanted to drop that here as an alternative solution to the patch https://www.drupal.org/project/gin_everywhere

We need a more in depth review other than posting two screenshots.

Here is a patch file for RC11, suitable for composer patches:

drupal.org/files/issues/2024-06-19/gin_3270626_cherrypick_for_rc11.patch

Just a cherry-pick of commit ee8cb77e refitted for RC11.
(Please do not use this patch file for issue development, use merge requests to resolve the issue)

@justanothermark I cherrypicked your suggestion from MR#305 / comment #23 onto MR#237. I suggest you close MR#305, no need to start a new MR, you can just acquire push access to the existing issue fork and commit there.

I also rebased MR#305 onto 8.x-3.x.

I rebased against 3.0-rc13.

@saschaeggi wouldn't it make sense to unify the entity create / edit forms in general, providing the sidebar by default?
I'm not aware of the technical reasons why currently only nodes use the sidebar, but from the user / UX perspective the current state seems inconsistent.

Users wonder why the Create / edit Taxonomy Term, Product, Block, ... entity forms look different from the node forms they mostly work with (and like a lot! <3)

Another option would be to have a settings page where the entity types can be selected that should use the sidebar?
Should we maybe widen the scope of this issue or is there already an existing plan to unify the UX for all entity forms by default?

Thank you!

Tested applicable MR https://git.drupalcode.org/project/gin/-/merge_requests/237

Published checkbox isn't part of gin-sticky-form-actions.