Prepare Drupal 10 compatibility (planned for August 2022).

Running drupal-check reports:

FILE: src/Access/MenuAdminPerMenuAccess.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      24   Call to deprecated function menu_ui_get_menus(). Deprecated 
                    in drupal:9.3.0 and is removed from drupal:10.0.0. Use      
                    Drupal\system\Entity\Menu::loadMultiple() instead.          
--------------------------------------------------------------------------------

FILE: src/MenuAdminPerMenuPermissions.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      26   Call to deprecated function menu_ui_get_menus(). Deprecated 
                    in drupal:9.3.0 and is removed from drupal:10.0.0. Use      
                    Drupal\system\Entity\Menu::loadMultiple() instead.          
--------------------------------------------------------------------------------

FILE: tests/src/Functional/MenuAdminPerMenuEnt
ityReferenceTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 172  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------

FILE: tests/src/Functional/MenuAdminPerMenuMenuPagesTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 245  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 283  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 319  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 353  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 388  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 443  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 448  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 465  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 470  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 487  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 492  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 514  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 519  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 542  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 547  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------

FILE: tests/src/Functional/MenuAdminPerMenuNod
eFormTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 151  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------
Check manually 165  Call to deprecated method drupalPostForm() of class         
                    Drupal\Tests\BrowserTestBase. Deprecated in drupal:9.1.0 and
                    is removed from drupal:10.0.0. Use $this->submitForm()      
                    instead.                                                    
--------------------------------------------------------------------------------

FILE: menu_admin_per_menu.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Thank's

Issue fork menu_admin_per_menu-3269896

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

S3b0uN3t created an issue. See original summary.

s3b0un3t’s picture

s3b0un3t
Primary language French
Location Nantes
commented
Issue summary: View changes
tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll work on this!

tmaiochi opened merge request !10

tmaiochi’s picture

tmaiochi commented
Version: 8.x-1.3 » 8.x-1.x-dev
Assigned: tmaiochi » Unassigned
Status: Active » Needs review

I fixed these messages: 

FILE: src/Access/MenuAdminPerMenuAccess.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      24   Call to deprecated function menu_ui_get_menus(). Deprecated 
                    in drupal:9.3.0 and is removed from drupal:10.0.0. Use      
                    Drupal\system\Entity\Menu::loadMultiple() instead.          
--------------------------------------------------------------------------------

FILE: src/MenuAdminPerMenuPermissions.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      26   Call to deprecated function menu_ui_get_menus(). Deprecated 
                    in drupal:9.3.0 and is removed from drupal:10.0.0. Use      
                    Drupal\system\Entity\Menu::loadMultiple() instead.          
--------------------------------------------------------------------------------
FILE: menu_admin_per_menu.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                    compatible with the next major version of Drupal core. See  
                    https://drupal.org/node/3070687.                            
--------------------------------------------------------------------------------

Because the drupalPostForm was fixed in #3013298: Entity reference to menu
Kindly review it!

Guilherme Rabelo’s picture

Guilherme Rabelo commented
Assigned: Unassigned » Guilherme Rabelo

Hi, i will review this.

Guilherme Rabelo’s picture

Guilherme Rabelo commented
Assigned: Guilherme Rabelo » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi, i applied the #5 patch and everything seens to be all rigth. The reported menssages were resolved.
Moving to RTBC!

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Needs work

Tests are failing for Drupal 10: https://www.drupal.org/pift-ci-job/2346149

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll work on this errors!

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned

I'm sorry, but I only managed to solve one of the errors in the tests, the others I don't know how to solve them. So I'm unassigning myself so that someone with more experience with testing can solve

rassoni’s picture

rassoni commented
Assigned: Unassigned » rassoni

DieterHolvoet made their first commit to this issue’s fork.

rassoni’s picture

rassoni commented
Assigned: rassoni » Unassigned

hershy.k made their first commit to this issue’s fork.

Update deprecated hook per change record - https://www.drupal.org/node/3180429

gquisini’s picture

gquisini commented
Assigned: Unassigned » gquisini

I'll work on this

gquisini’s picture

gquisini commented
Assigned: gquisini » Unassigned

Sorry guys,
I'm a newbie to drupal, and I don't really know how to resolve the errors in the tests. BUT, using the upgrade status module (https://www.drupal.org/project/upgrade_status) with the MR 10, it shows that it is ready for drupal 10.

sophiavs’s picture

sophiavs commented
Assigned: Unassigned » sophiavs

Hi i'll be trying to work on this

sophiavs’s picture

sophiavs commented
Assigned: sophiavs » Unassigned
Status: Needs work » Reviewed & tested by the community

I did some tests and tried the test here in drupal site, all of those seems to be working fine with drupal 10. For me there is no need for more work and is RTBC.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented

  • JeroenT committed 72c7ce3 on 8.x-1.x authored by tmaiochi 
    Issue #3269896 by tmaiochi, DieterHolvoet, hershy.k, S3b0uN3t, Guilherme...
jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.