Problem/Motivation

This issue is a basically a copy of #3222799: Order of toolbar menu items is changed after updating to 1.0.0-beta18 created separately here so that both Gin and Gin Toolbar can be patched.

The order of the menu items is changed.

Was: Content > Structure > Appearance > Extend > People > Configuration > Reports > Help
Before

Now: Content > Structure > Appearance > Extend > People > Reports > Configuration > Help
Now

Per the comment by @saschaeggi in the related issue, this was a desired change:

... But in our A/B Test (with content editors from various clients) found that it was easier for them to find the configuration as it was always 'at the end' of the navigation (especially for the vertical variant). So they don't have to 'scan' the navigation for the config item. That's why this change was made firsthand.

It seems to makes sense to at least let sites opt out of this behavior so that the order is determined by the menu admin UI.

Steps to reproduce

Upgrade from 1.0.0-beta17 to 1.0.0-beta18

Proposed resolution

Ultimately, if the Gin team feels this is a necessary change, maybe it should be done by changing the actual weights of the menu items so that Drupal core functionality is not ignored and site admins could control it?

For now, we could add a configuration setting for this.

Remaining tasks

  1. Create patch
  2. Test
  3. Merge changes

User interface changes

New config field added to settings form.

Issue fork gin-3269548

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jrb created an issue. See original summary.

jrb’s picture

Status: Active » Needs review
StatusFileSize
new2.69 KB

Attached patch adds a new "Rearrange Admin menu items" setting to Gin.

Related patch for Gin Toolbar here: #3222799-9: Order of toolbar menu items is changed after updating to 1.0.0-beta18.

shyam_bhatt’s picture

Assigned: Unassigned » shyam_bhatt
shyam_bhatt’s picture

StatusFileSize
new9.64 KB
new8.84 KB
new9.75 KB

I have checked the above patch: 3269548-2.gin_.add-rearrange-menu-items-setting.patch in the theme.
Before adding the patch, the "Rearrange Admin menu items" toggle button is not visible on the gin theme setting page.
before-3269548-4.png
After adding the patch, the "Rearrange Admin menu items" toggle button is visible on the gin theme setting page. Once we enable it the "configure" and "help" menus will be moved to the last position.
after-toggle-button-3269548-4.png
after-3269548-4.png

shyam_bhatt’s picture

Assigned: shyam_bhatt » Unassigned
Status: Needs review » Reviewed & tested by the community

ELC made their first commit to this issue’s fork.

anskelt’s picture

Stopped working for me after RC11

so i updated previous patch to work with updated release candidate.

leducdubleuet’s picture

Can we expect this option to be committed to the theme?

martijn de wit’s picture

Would be nice if the merge request is updated with the latest changes from #8

Rajeshreeputra made their first commit to this issue’s fork.

anskelt’s picture

Any ETA on when this will get into 4.0?

anskelt’s picture

adding a new updated patch again to work with 4.0

bohus ulrych’s picture

Thanks @anskelt for patch #13, it still works even with 5.0.2