Project Browser Initiative Meeting for [January 12, 2022] [#3264400]

1️⃣ We have fizzled a bit, and I'm concerned about it. I'm hoping it was just the holidays, but we really need to tap some resources to do some of the heavy lifting here. Two big things are, like I've mentioned - (1) the migration of release nodes into the D9 site, and ...

gaurav.kapoor	I don't have much experience in migration, is it just migration of single content type from D7 to D9 along with entity reference fields? I can do a dummy setup in my local, try writing a migration for this and then only I'll be able to commit for this.
gaurav.kapoor	Isn't it high time for Drupal.org to migrate to D9 :stuck_out_tongue_closed_eyes:
chrisfromredfin	Yes, we're actually helping do that part. :slightly_smiling_face:
chrisfromredfin	writing some migrations for them to use when they really do migrate
Gábor Hojtsy (he/him)	I believe @grasmash did the migration part to a temporary copy already?
chrisfromredfin	not for releases
chrisfromredfin	just for project_module
Gábor Hojtsy (he/him)	Hm, ah

3️⃣ We actually merged something! Thanks to @gaurav.kapoor and @Rajab Natshah we've got good work happening. However, When I spin up a GitPod (cc: @shaal) and go to the extend page I can still see that it's making a call to /project and it just spins and spins and those requests never complete. on my local, this patch seemed to fix that issue... but perhaps it does not? Or, what code does GitPod pull? Having the GitPod link I believe is key to allowing our Site Builder Subcommittee to easily see the state of things and work with something real and clickable to suggest improvements. How do we get something functional?!

shaal	I just opened in Gitpod the previous issue (3240318)
shaal	Let me check what I can see
leslieg	Yes it would be helpful to be able to launch a working prototype of the Project Browser. Currently both links off the Project Browser project page are not functioning - gitpod and simplytest.me
shaal	TIL - you don't have to be logged in to see this page -https://8080-purple-owl-m8jie4i3.ws-us25.gitpod.io/admin/modules/browse
chrisfromredfin	Ha! Good find. Wonder if I care or not? Probably so cuz it will tell you what you have installed eventually. I'll file an issue! (Or do you want to)
shaal	@chrisfromredfin I think it gets stuck with this -onMount(async () => { // todo Make this URL dynamic. It would work to simply change this to // "/drupal-org-proxy/project" for when the Svelete JS is loaded within a Drupal page, // but that would not work during development when viewing the Svelte app on http://localhost:5000/. const res = await fetch(`/drupal-org-proxy/project`); data = await res.json(); });
shaal	What is /drupal-org-proxy/project ?Is there something else I need to install ?
chrisfromredfin	It should basically never be asking for that URL without a query string.
chrisfromredfin	like ti shouldbe like at least ?page=0
chrisfromredfin	but it's requesting every. single. project. from drupal.
chrisfromredfin	and I thought #3227738: Fix Drupal routing and Svelte app routing would fix it
chrisfromredfin	but it actually wouldn't since it's still requesting that URL: + const res = await fetch(drupalSettings.project_browser.origin_url + "/drupal-org-proxy/project");
chrisfromredfin	just doing it with a base url now lol
chrisfromredfin	@Rajab Natshah do you agree that we shouldn't be making a blanket request to /drupal-org-proxy/project?
Rajab Natshah	@chrisfromredfin Yes
shaal	I installed a fresh new D9 website locally
shaal	+ project browser.I see the same problem -
shaal	image.png
shaal	spinning with no results
shaal	What am I missing?
chrisfromredfin	Nothing. Certainly doesn't have anything to do with GitPod. I don't think that onMount() call should be made.
shaal	Oh, reloading the page after a few minutes - and I see the results!
Rajab Natshah	@chrisfromredfin I had time to study the Drupal.org REST and other APIshttps://www.drupal.org/drupalorg/docs/apis/rest-and-other-apis
Rajab Natshah	https://www.drupal.org/api-d7/node.json?type=project_module
Rajab Natshah	"self": "https://www.drupal.org/api-d7/node?type=project_module", "first": "https://www.drupal.org/api-d7/node?type=project_module&page=0", "last": "https://www.drupal.org/api-d7/node?type=project_module&page=962", "next": "https://www.drupal.org/api-d7/node?type=project_module&page=1",
Rajab Natshah	Should pass the args .. and follow the API for the number of items on each pageeasier coding and easier for rendering too (edited)
shaal	@chrisfromredfin please ping me if there's anything on the DrupalPod side I can help with
chrisfromredfin	will do, thanks @shaal - only one question, the button on the home page, what does it build from? the -dev release, or the HEAD in git or what. That is, how soon after merging something can I expect the DrupalPod link to reflect that change
chrisfromredfin	@Rajab Natshah I'm mad now because my theory was wrong. I got rid of the generic call in App.svelte and now it's ONLY making the right requests, and that's still pending forever... why?!
chrisfromredfin	image.png
Rajab Natshah	@chrisfromredfinThe API Call + Cache + RenderNot sure which one should be first.Call the API and cache before going into the test?Cache first or render first?The automated test is flickeryIt will pass one. Then fail. then pass.Listed that in my report finding at this issue---Same for normal use too. The API Call + Cache + Render (edited)
shaal	@chrisfromredfin the link in project_browser main page, is set to use version 1.0.x of the module (with Drupal 9.3.x)As soon as you make a commit in Drupal git for the project, open DrupalPod from the project_browser main page, and you should see the latest changes.(there's no caching, each new workspace loads the latest version available)
chrisfromredfin	Thanks, @shaal!
chrisfromredfin	Not sure what you're saying @Rajab Natshah are you saying that is related here to this issue?
Rajab Natshah	Audio Audio time scrubber, 0 seconds / 1 minute, 7 seconds1:071x
chrisfromredfin	Aha, I thought that's what the "Fixture" was doing was pre-warming the cache. Got it. OK. Thanks for this - but in general, good - change the caching mechanism and remove the fixture. :thumbsup: thanks!

5️⃣ We had a good discussion yesterday on the Site Builders Subcommittee meeting about the short user-friendly project descriptions that will be displayed on the PB results page (card or list view). See thread 3 from yesterdays meeting above and chime in with any additional thoughts. We are looking into having members of the Discover Drupal program help with the process of creating the short description and logos, creating issues in the project issue queues and working with maintainers on this. Key idea is that the short descriptions are helpful to site builders and those new to Drupal - answering the question - What solution does this module provide?

Rajab Natshah	@leslieg Really nice PB fieldsField description (field_project_description )Field logo icon (field_project_logo_icon)Field logo (field_project_logo)
Gábor Hojtsy (he/him)	Is the plan to share the suggested text with maintainers 1-1 and request them to use it?
leslieg	@Gábor Hojtsy (he/him) The current thinking is that we will create an issue in each of the project queues for the short description and logo (for the Top 100 most popular modules to start), allow contributors to add suggestions there, have a mentor review the issue if helpful (especially for Discover Drupal participants) and then assign to the maintainer to review and take action on if they agree. Input on this process from you and others is welcome. (edited)
leslieg	Also need a step in there for the PB Sitebuiders subcommittee to review the description to make sure it meets the goal of easy to understand for site builders

Issue for permissions: #3258247: Add permissions to the project browser route

Gábor Hojtsy (he/him)

submitted an MR, there were plenty TODOs calling it an access bypass >D

ANSWERED :) Over in https://drupal.slack.com/archives/C226VLXBP/p1642010838098900 @Bisonbleu has a question: what is the practice around case for package: values in module info.yml? From a quick look I think it is sentence case ("User interface" not "User Interface"). Bison noted that his modules page listed "User Interface" and "User interface" both as separate sections.I wondered if someone here had a dataset which might indicate if there's a clear behaviour. I think core - at least mostly - uses sentence case ("User interface"). (edited)

xurizaemon	https://www.drupal.org/docs/creating-custom-modules/let-drupal-know-abou... is not specific (but it could be updated if there is a clear winner)
xurizaemon	aha https://www.drupal.org/node/542202 actually recommends "User interface" and says this If present, the package string groups modules together on the module administration page (admin/modules); the string should therefore be the heading you would like your modules to appear under, and it needs to be consistent (in spelling and capitalization) in all .info files in which it appears. It should not use punctuation and it should follow the Drupal capitalization standard as noted above.Capitalization is important because package string is case sensitive, and using package = fields in one module and package = Fields in another would yield two different packages on the module administration page. This can be highly confusing as Seven (the default administrative theme) capitalizes fieldset legends, making fields and Fields indistinguishable. Using package = Fields is the correct way.
xurizaemon	Found the underlying answer, intrigued if there is some cache of project metadata which folks here know about, let me know if so :)
chrisfromredfin	This is the best we got: https://datastudio.google.com/u/0/reporting/9c1a4c31-fb9a-4d48-a517-c7fc... -- there's nothing as a result of parsing .info.yml's though.
xurizaemon	thanks Chris! I was guessing you might have something like that, given lets4's post to the "Migrate" module category issue :smile:
xurizaemon	is it access controlled? I just have this
chrisfromredfin	weird; no it is coming up for me but I don't believe it's access-controlled. @Andrew Olson (andrewozone he/him) is the owner in case that's needed.
Andrew Olson (andrewozone he/him)	The Google Data Studio link is not access controlled. I was able to visit and see results and apply the filters. It might not have been visited in a while so maybe went "inactive" (just a guess, I don't know how Google works this). But regardless, you should see it now (same link as above but reposted in context): https://datastudio.google.com/reporting/9c1a4c31-fb9a-4d48-a517-c7fcdbb5...
tim	So wasn't sure what you were meaning by meta data, @xurizaemonI have more info .... It gets a bit complicated.Its in spreadsheet form that isn't well documented. Datastudio makes it nice and organized! I can share a link with you if you would like to the spreadsheet I have. Probably good to spend some time and explain it.Or I am willing to share results of what you are looking for. Just let me know. (edited)
tim	I don't have everything yet that I would like - so is still a work in progress.
tim	A sample
xurizaemon	I'll take another look at the Data studio today if i get a chance (weekend here now). Mostly: I saw a support question (OP) and knew from recent discussion (#3257701: Add module category "Migrate") that data to answer it likely existed somewhere; I try to learn by answering questions, and sharing. So I asked here :)
xurizaemon	But also - I'm interested to see your call for migrate hands as part of project browser. I can't commit specifics right now, but please keep me in mind as it's a thing I'm doing lots of currently!
xurizaemon	My question here boiled down to select count(*), case_format(package) from modules group by case_format(package) (case_format is imagined and returns "Title case" if the first character after a space is a capital, else it returns "Sentence case", furious hand waving) (edited)
xurizaemon	The question though was already answered by finding that we recommended sentence case in D7 module docs, i added docs to D8+ now