Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
forum.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Jan 2022 at 23:10 UTC
Updated:
5 May 2024 at 08:49 UTC
Jump to comment: Most recent
Comments
Comment #2
larowlanEmailed the current owner of the forum project to allow us to use that namespace
Comment #4
larowlanComment #6
gábor hojtsyAre all forum tests self contained in the module? If not, first we would need a core fix to move the tests around to make sure they are removed with the module and moved to contrib with the module. #3263654: Move all HAL tests to the module in preparation of removal in D10 is an example for the same thing in HAL. This would need a pre-quel issue first for that unless its self-contained.
Comment #7
bbralaWe need to clean up core first, preferable move as much tests to the module namespace to make the transition as easy as possible. Also backporting tests to 9.4 will be easier that way.
Blocking on #3264347: Move all forum tests to the module in preparation of removal in Drupal 10.
Comment #9
quietone commentedI know this is postponed but the migration tests won't be moving to forum and I wanted to see what is failing. But it seems I am foiled again, this needs a rebase and once again I am not able to push after a rebase. Sigh.
I checked to see what migrations tests use the word 'forum' and found 49, using
$ grep -ri forum core | grep -v .js | grep -v fixture | grep -i migrate | grep Test | awk -F: '{print $1}' | sort -u | nl. We need to think about how to manage these and it is too late for me to that now.Comment #10
quietone commentedThis is removing forum related processes from some migrations such that the upgrade path will be broken when run from contrib. We need to make sure that the upgrade path for forum works from contrib before removing this module from core.
Comment #11
bbralaAdded the existing issue regarding tests to related issues.
Comment #12
quietone commentedThat is better, all the migration tests are passing now, and these can not be moved in to the forum module.
I'll leave it to others to check if any of the other failing tests can be moved to forum. I did notice this one which looks like a candidate for moving, Drupal\Tests\node\Functional\NodeAccessPagerTest::testForumPager.
Comment #13
kristen polI'm confused... @larowlan asked for a new issue to be created for removing tests in the d10readiness channel so someone I'm mentoring for this did so (see comment #11) but it looks like @quietone has been working on removing the tests on this issue?
@larowlan Please provide some guidance on how to proceed please. I hate seeing this wasted duplicate effort. Thanks.
Comment #14
kristen polCaught up on Slack with @larowlan and @xjm and updated the comment on the tests issue so the work can continue on there. Thanks, everyone!
https://www.drupal.org/project/drupal/issues/3264195#comment-14414140
Comment #15
quietone commentedComment #16
quietone commentedComment #17
quietone commentedComment #18
chris matthews commentedSince Drupal 10.0.0-beta1 and 9.5.0-beta1 are right around the corner, the Forum module would need to be removed in Drupal 11 (not Drupal 10), correct?
Comment #19
quietone commentedComment #20
gábor hojtsyUpdating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...
Comment #21
quietone commentedWe should add the changes from #3409384: [11.x] Remove forum CSS from themes and profiles and close that.
Comment #22
quietone commentedComment #27
spokjeAll test-failures are related to update-tests and thus to fixtures needing to be updated.
Which is great, because that should be all that was expected to be remaining.
So this is now, at the very least, postponed on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x.
I've searched around for mentions of
forum, but all/most of them seem to be migration related.I'm sure more eyes will be prying the code-base to assure of that.
For now I think this has been a very successful deprecation process, we seem to have ironed out most kinks we occurred during the Deprecation Dance D9=>D10, so well done all involved!
Comment #28
quietone commentedComment #29
quietone commentedAt first Forum was to be removed from theme as part of the deprecation process and therefore it has a separate issue, #3409384: [11.x] Remove forum CSS from themes and profiles. But there is no need for it to be separate anymore so I have moved those changes to this MR.
Created the CR
Comment #33
quietone commentedThere were 17 failed Functional tests before bringing in those changes and now there are 18. I have not looked into the details yet but let's continue here. I have closed the other issue as a duplicate and am moving credit.
Comment #35
quietone commentedComment #36
spokjeTurns out
\Drupal\Tests\taxonomy\Functional\Update\NullDescriptionTestwas added between the testruns by me and @quietone.That one should fail (since it uses a 9.4.4 fixture) and it did, causing a +1 on test-failures.
So no new failures were introduced by merging #3409384: [11.x] Remove forum CSS from themes and profiles into this MR.
Comment #37
quietone commentedWhile we should run spellcheck it is unfortunate that the dictionary is out of sync again.
Comment #38
rosk0Needs rebase with conflict resolution.
Not postponed anymore as #3264195: Move non-migration tests to Forum in preparation for deprecation have landed.
Comment #39
quietone commentedThe issue summary shows this as postponed on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x. We need the upgrade path and tests working first.
Comment #40
catchComment #41
catchTests are green.
Comment #42
smustgrave commentedCspell might be out of sync again. But removal seems good. Was previously green so doubt removing that word is going to break.
CR is there so removing tag.
Not sure what was needed for release note other then it’s been removed so leaving that.
Comment #44
alexpottComment #45
alexpottCommitted f1ac9b6 and pushed to 11.x. Thanks!