Problem/Motivation

Remove forum module from Drupal 11.

Steps to reproduce

Proposed resolution

Remaining tasks

postponed on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x

User interface changes

API changes

Data model changes

Release notes snippet

Forum module has been removed in 11.x

Issue fork drupal-3261653

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Emailed the current owner of the forum project to allow us to use that namespace

Hi Peter

We're looking to move forum module out of core (see
https://www.drupal.org/project/ideas/issues/1898812) and were hoping to use
the 'forum' namespace in contrib.

I see you already have it, but there is no code pushed.

Can we use that namespace?

If so, can you add myself (larowlan) and andypost as maintainers.

Thanks

Lee

larowlan’s picture

Status: Active » Needs review

kim.pepper made their first commit to this issue’s fork.

gábor hojtsy’s picture

Are all forum tests self contained in the module? If not, first we would need a core fix to move the tests around to make sure they are removed with the module and moved to contrib with the module. #3263654: Move all HAL tests to the module in preparation of removal in D10 is an example for the same thing in HAL. This would need a pre-quel issue first for that unless its self-contained.

bbrala’s picture

Title: Remove Forum module from Drupal 10 » [PP-1] Remove Forum module from Drupal 10
Status: Needs review » Postponed
Related issues: +#3264347: Move all forum tests to the module in preparation of removal in Drupal 10

We need to clean up core first, preferable move as much tests to the module namespace to make the transition as easy as possible. Also backporting tests to 9.4 will be easier that way.

Blocking on #3264347: Move all forum tests to the module in preparation of removal in Drupal 10.

quietone made their first commit to this issue’s fork.

quietone’s picture

I know this is postponed but the migration tests won't be moving to forum and I wanted to see what is failing. But it seems I am foiled again, this needs a rebase and once again I am not able to push after a rebase. Sigh.

I checked to see what migrations tests use the word 'forum' and found 49, using $ grep -ri forum core | grep -v .js | grep -v fixture | grep -i migrate | grep Test | awk -F: '{print $1}' | sort -u | nl. We need to think about how to manage these and it is too late for me to that now.

quietone’s picture

Issue summary: View changes

This is removing forum related processes from some migrations such that the upgrade path will be broken when run from contrib. We need to make sure that the upgrade path for forum works from contrib before removing this module from core.

bbrala’s picture

Added the existing issue regarding tests to related issues.

quietone’s picture

That is better, all the migration tests are passing now, and these can not be moved in to the forum module.

I'll leave it to others to check if any of the other failing tests can be moved to forum. I did notice this one which looks like a candidate for moving, Drupal\Tests\node\Functional\NodeAccessPagerTest::testForumPager.

kristen pol’s picture

I'm confused... @larowlan asked for a new issue to be created for removing tests in the d10readiness channel so someone I'm mentoring for this did so (see comment #11) but it looks like @quietone has been working on removing the tests on this issue?

@larowlan Please provide some guidance on how to proceed please. I hate seeing this wasted duplicate effort. Thanks.

kristen pol’s picture

Caught up on Slack with @larowlan and @xjm and updated the comment on the tests issue so the work can continue on there. Thanks, everyone!

https://www.drupal.org/project/drupal/issues/3264195#comment-14414140

quietone’s picture

chris matthews’s picture

Since Drupal 10.0.0-beta1 and 9.5.0-beta1 are right around the corner, the Forum module would need to be removed in Drupal 11 (not Drupal 10), correct?

quietone’s picture

Title: [PP-1] Remove Forum module from Drupal 10 » [PP-1] Remove Forum module
Version: 10.0.x-dev » 11.0.x-dev
gábor hojtsy’s picture

Version: 11.0.x-dev » 11.x-dev
Issue tags: +Major version only

Updating title, tags and version number based on recent announcement at https://www.drupal.org/about/core/blog/new-drupal-core-branching-scheme-...

quietone’s picture

We should add the changes from #3409384: [11.x] Remove forum CSS from themes and profiles and close that.

quietone’s picture

Issue summary: View changes

Spokje made their first commit to this issue’s fork.

Spokje changed the visibility of the branch 11.x to hidden.

Spokje changed the visibility of the branch 3261653-remove-forum-module to hidden.

spokje’s picture

All test-failures are related to update-tests and thus to fixtures needing to be updated.
Which is great, because that should be all that was expected to be remaining.
So this is now, at the very least, postponed on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x.

I've searched around for mentions of forum, but all/most of them seem to be migration related.
I'm sure more eyes will be prying the code-base to assure of that.

For now I think this has been a very successful deprecation process, we seem to have ironed out most kinks we occurred during the Deprecation Dance D9=>D10, so well done all involved!

quietone’s picture

Title: [PP-1] Remove Forum module » Remove Forum module
Issue summary: View changes
quietone’s picture

At first Forum was to be removed from theme as part of the deprecation process and therefore it has a separate issue, #3409384: [11.x] Remove forum CSS from themes and profiles. But there is no need for it to be separate anymore so I have moved those changes to this MR.

Created the CR

quietone credited andypost.

quietone credited catch.

quietone’s picture

There were 17 failed Functional tests before bringing in those changes and now there are 18. I have not looked into the details yet but let's continue here. I have closed the other issue as a duplicate and am moving credit.

quietone credited lauriii.

quietone’s picture

spokje’s picture

There were 17 failed Functional tests before bringing in those changes and now there are 18

Turns out \Drupal\Tests\taxonomy\Functional\Update\NullDescriptionTest was added between the testruns by me and @quietone.

That one should fail (since it uses a 9.4.4 fixture) and it did, causing a +1 on test-failures.
So no new failures were introduced by merging #3409384: [11.x] Remove forum CSS from themes and profiles into this MR.

quietone’s picture

While we should run spellcheck it is unfortunate that the dictionary is out of sync again.

rosk0’s picture

Status: Postponed » Needs work

Needs rebase with conflict resolution.

Not postponed anymore as #3264195: Move non-migration tests to Forum in preparation for deprecation have landed.

quietone’s picture

Status: Needs work » Postponed (maintainer needs more info)

The issue summary shows this as postponed on #3414563: Add new 10.3.x database dump fixtures, without modules deprecated for removal in 11.x. We need the upgrade path and tests working first.

catch’s picture

Status: Postponed (maintainer needs more info) » Needs work
catch’s picture

Status: Needs work » Needs review

Tests are green.

smustgrave’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs change record

Cspell might be out of sync again. But removal seems good. Was previously green so doubt removing that word is going to break.

CR is there so removing tag.

Not sure what was needed for release note other then it’s been removed so leaving that.

alexpott made their first commit to this issue’s fork.

alexpott’s picture

alexpott’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Needs release note

Committed f1ac9b6 and pushed to 11.x. Thanks!

  • alexpott committed f1ac9b6c on 11.x
    Issue #3261653 by Spokje, catch, larowlan, quietone, kim.pepper,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.