Problem/Motivation

Deprecated forum module in Drupal 10.1

Steps to reproduce

Proposed resolution

Remaining tasks

See parent issue for issues that needs to be completed before this one

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3261652

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !1756

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

Real test failures, probably the confirmation form?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Needs review

Yeah its the new 'confirm you want to enable deprecated modules' confirmation form

catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Looks great!

catch’s picture

catch
he/him
Primary language English
commented

We need a release on https://drupal.org/project/forum before we can go ahead here.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I've created a sub-tree split and pushed the history to the 1.x branch of the contrib project.
I've pushed a 1.0.0 tag but d.o isn't letting me create a release.
Have asked for a second set of eyes in #drupalorg on slack.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

https://www.drupal.org/project/forum now has a 1.0.0 release equivalent to 9.3.4

xjm’s picture

xjm
she/her
Primary language English
commented

Great to see this RTBC!

One question, should we be marking forum's tests as legacy? (See also #3257127: Trigger a deprecation message when a deprecated module or theme is enabled.)

xjm’s picture

xjm
she/her
Primary language English
commented

Let's postpone these one more time on #3257127: Trigger a deprecation message when a deprecated module or theme is enabled, which will also help us make sure we've properly identified or decoupled all the forum integration tests, etc.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Postponed (maintainer needs more info) » Postponed
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

The lifecycle link should link to https://www.drupal.org/about/core/policies/core-change-policies/deprecat.... I'll update that page and unpublish the newer duplicate once this is unpostponed

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Postponed » Needs review

I think we just need to work out where to link to here

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

Looks good!

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Needs review

Mark the forum tests deprecated

quietone’s picture

quietone commented
Status: Needs review » Reviewed & tested by the community

There is no need to deprecate tests. The What we can not deprecate section of the deprecation policy states, "Do not deprecate test classes".

Restoring the RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

I think perhaps the lifecycle link needs to go back to the old one

catch’s picture

catch
he/him
Primary language English
commented

Sent for a retest since I think we will need to mark all of forum's tests @group legacy now that deprecations are triggered when deprecated module are enabled.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Yep, needs @group legacy on forum's own tests.

spokje’s picture

spokje
Primary language Dutch
commented

Hate to spoil the party, but I think at the very least the help_topics about forum should be moved into the forum module itself before deprecation? I'm pretty sure that should happen before removal.

Looks like there are no tests for the module scattered around the place BTW.

INSTA-EDIT: Since forum has config, deprecating it will hit #3265546: Drupal\KernelTests\Config\DefaultConfigTest throws deprecation notice for deprecated Core modules/themes which have config as a blocker.

quietone’s picture

quietone commented
Parent issue: #3118154: [meta] Deprecate dependencies, libraries, modules, and themes that will be removed from Drupal 10 core by 9.4.0-beta1 » #3267261: [Meta] Tasks to deprecate Forum
quietone’s picture

quietone commented
Issue tags: +Needs change record
sahilgidwani’s picture

sahilgidwani commented
Status: Needs work » Fixed
spokje’s picture

spokje
Primary language Dutch
commented
Status: Fixed » Needs work

I like the optimism there, but restoring status to NR.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

catch’s picture

catch
he/him
Primary language English
commented
Title: Deprecate Forum module in Drupal 9.4 » Deprecate Forum module in Drupal 10.1
Issue summary: View changes

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Title: Deprecate Forum module in Drupal 10.1 » Deprecate Forum module in Drupal 10

smustgrave made their first commit to this issue’s fork.

smustgrave opened merge request !6274

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3409384: [11.x] Remove forum CSS from themes and profiles

it still depends on deprecation of templates #3409384: [11.x] Remove forum CSS from themes and profiles

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Postponed
quietone’s picture

quietone commented
Status: Postponed » Active

quietone closed merge request !1756

quietone’s picture

quietone commented
Status: Active » Needs review
Issue tags: -Needs change record
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Updated the link as it appears the anchor on https://www.drupal.org/node/3223395 is s-forum.

All green so all legacy tags added.

smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Needs work

Ugh my suggestion got bit by the spell-check bug, may just need to be rebased.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Needs work » Needs review

Rebased and found one straggler.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks @Spokje!

quietone’s picture

quietone commented

There is a stable release of Forum in contrib but it was released 4 February 2022. That should be updated before this is committed.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Looking for the docs on subtree split - from memory I think dww created some - will sort forum release once I find them

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Found the docs https://www.drupal.org/about/core/policies/core-change-policies/module-o...

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Updated at https://www.drupal.org/project/forum/releases/1.0.1

#3387172: Unpublished forum accessible to public
#2936995: Add taxonomy term revision UI

Looked to be the only changes since 1.0.0

  • larowlan committed 93b747d5 on 11.x 
    Issue #3261652 by larowlan, smustgrave, quietone, Spokje, paulocs:...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

🎉🎉🎉 Committed to 11.x and pushed.

Thanks everyone 🎉🎉🎉

larowlan closed merge request !6274

andypost’s picture

andypost
he/him
Primary language Russian
commented

Thank you 👍

johnwebdev’s picture

johnwebdev commented

It is not clear to me if this module is being deprecated in 10 or 11. The change records suggests it will be removed in 11, but the merged code looks like it gets deprecated in 11. :)

catch’s picture

catch
he/him
Primary language English
commented

@johnwebdev the commit was made to 11.x, but we branched off the 10.3.x branch from 11.x just after it was made, so it's now deprecated in both the 10.3.x and 11.x branches.

What this means is:

1. 10.3.0+ sites will get a warning that core forum module is deprecated, and will be encouraged to install the contrib forum module.

2. We still need to actually remove forum module from the 11.x branch/11.0.0, that will happen in #3261653: Remove Forum module.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Version: 11.x-dev » 10.3.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Thanks @johnwebdev @catch - I updated the text on the CR to make it clear that 10.3.0 is the point at which the status page will start to report on the deprecation

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.