Problem/Motivation

In collectCoreDeprecatedAndObsoleteExtensions(), obsolete modules like simpletest will be reported as being enabled even when they are disabled.

Proposed resolution

Check $extension->status and only report those that are enabled.

Issue fork upgrade_status-3261167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

Liam Morland opened merge request !20

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Assigned: liam morland » Unassigned
Status: Active » Needs review
socialnicheguru’s picture

socialnicheguru commented

i do want modules that are disabled to be reported on

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Interesting point that it could still be useful to report on obsolete/deprecated CONTRIBUTED extensions even if they are disabled, as this would underline the need to remove them and move on from them. (In case they were kept in the codebase for future use). However contributed projects could also include several extensions that may indepdendently be obsolete but you got them as a package, so you cannot / should not do much about them in that case either. Hm.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

As I understand it, collectCoreDeprecatedAndObsoleteExtensions() only looks at core. So it would be a separate issue to change the handling of obsolete/deprecated contrib.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Uh oh that is true :D The deprecation / obsolete marking system is to be used by contributed projects too, not sure why did I implement this only for core, but for core, definitely disabled extesions should not be reported on in this report. We should have a separate issue to general this to all extensions, but that will need to consider if a disabled sub-extension is part of a non-deprecation/not obsolete parent extension, and not report on it then. This fix should be good though and good find @Liam Morland.

  • 8266a39 committed on 8.x-3.x 
    Issue #3261167 by Liam Morland: Do not report disabled modules in...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed this. Thanks again @Liam Morland!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.