Closed (fixed)
Project:
Upgrade Status
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
26 Jan 2022 at 19:05 UTC
Updated:
23 Feb 2022 at 02:24 UTC
Jump to comment: Most recent, Most recent file
Show commands
changes
Comments
Comment #2
gábor hojtsyThe lifecycle link should be displayed with this warning, which should explain the situation. Eg. https://git.drupalcode.org/project/drupal/-/blob/9.4.x/core/modules/enti... is still present in Drupal 9.4.x. It is hidden, so you would not see it in the module list.
Comment #3
liam morlandThe message implies that I should uninstall these modules as part of preparing for Drupal 10. Is there actually something I can do to clear this message?
Comment #4
gábor hojtsyIt is supposed to lead you to the docs about what to do about them (from the lifecycle link in the info file). Is that shown?
Comment #5
liam morlandUnder the "Requirement" column, there is no text other than:
Comment #6
gábor hojtsyHm, sounds like this is not implemented completely then. It should have been something like this. Can you test this?
Comment #7
gábor hojtsyComment #9
gábor hojtsyLol I see my quick patch did not close the link tags 🙈 That will need fixing.
Comment #10
gábor hojtsyThanks for fixing that in the MR, however you undid the translatability of the "read more" text. (I think lowercasing that is fine, but it would be important to keep it translatable).
Comment #11
liam morlandThanks for the patch. I included the module name in the link so that the link is not just "read more", which is a problem for accessibility.
It is helpful to have the link to the documentation. It still doesn't tell me what I have to do to fix the problem. I tried
drush pm:uninstall simpletestbut it still shows up in this section of the Upgrade Status report.Comment #12
gábor hojtsyLiam: what's your core version? The action to take (or not take) would depend on the module.
For example entity reference used to be its own module but got integrated in the field system, and remained as an empty module for backwards compatibility purposes (such as dependencies of contributed modules). However an update function should have uninstalled (or will uninstall) it.
On the other hand Quickedit module is about to be deprecated in Drupal 9.4.x and to be removed in Drupal 10. However that will NOT to be uninstalled automatically, it should be replaced as part of the Drupal 10 update with the contributed project that will host the code.
So I think its the role of the docs on the lifecycle_link page to explain what to do about each module.
Comment #14
gábor hojtsyThanks for your help fixing the lack of link. I don't think more is within the possibility of upgrade status given the reasons for module lifecycle statuses could be different. So trying to set this appropriate for the remaining discussion in case we figure out there is some change we can make anyway :D
Comment #15
liam morlandI'm running Drupal 9.3.
I agree that it should be up to the lifecycle link to describe what should be done. I think it would be a separate documentation ticket in another queue to request that update. So this can probably be marked as a fixed feature request.
Comment #16
liam morlandModules like simpletest were uninstalled automatically in #3111645: Uninstall entity_reference module and prevent it being enabled again, remove deprecated code. However, they are still reported by update_status. Fix is in #3261167: Do not report disabled modules in collectCoreDeprecatedAndObsoleteExtensions().