QuickEditJavascriptTestBase is test base class but not declared abstract. It's causing the following error with PHPStan
-
message: "#^Drupal\\\\Tests\\\\BrowserTestBase\\:\\:\\$defaultTheme is required\\. See https\\://www\\.drupal\\.org/node/3083055, which includes recommendations on which theme to use\\.$#"
count: 1
path: modules/quickedit/tests/src/FunctionalJavascript/QuickEditJavascriptTestBase.php
Look @ \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditJavascriptTestBase, see it's not abstract.
Define as abstract
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3260707-10.patch | 626 bytes | spokje |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !1721 Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
mglamanThis may be irrelevant since PHPStan only runs on 10.0.x and QuickEdit is slated to be removed. But raising it anyways
#3227033: Remove Quick Edit from core
Comment #4
dwwYeah, this can be moved to the quickedit issue queue once I subtree split core's quickedit module, push that back into the contrib git repo and cut a contrib release.
Thanks,
-Derek
Comment #5
mglamanCool, thanks dww!
Comment #6
dwwThe 1.0.x branch's tests are failing, I believe because of this issue.
https://www.drupal.org/pift-ci-job/2305738
Seems this should block 1.0.0 final. I'll take a look ASAP.
Thanks,
-Derek
Comment #7
dwwAlso, since this started as a core bug report, tagging for Bug Smash. 😉
Comment #10
spokjeComment #12
mradcliffeI think fixing the failing tests is out-of-scope for this issue and the merge request (or patch) gets the tests to run so +1 RTBC.
Comment #13
spokjeBumping to Priority
Criticalsince this is blocking Critical issue #3261096: Include quickedit plugins from editor and image modulesComment #14
spokjeTo Needs Review since fixing the tests is for #3261254: Failing test Drupal\Tests\quickedit\FunctionalJavascript\SettingsTrayIntegrationTest::testQuickEditLinks
Comment #16
dwwSorry, @mglaman -- I told d.o to make you the author of that commit, but when I pressed 'Merge', that didn't happen. Alas.
Anyway, yay!
Thanks y'all,
-Derek
Comment #17
mglaman@dww no probem :) that's why issue credits exist