Closed (fixed)
Project:
Quick Edit
Version:
1.0.0
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Jan 2022 at 01:58 UTC
Updated:
25 Feb 2022 at 02:44 UTC
Jump to comment: Most recent
Problem/Motivation
#3227033: Remove Quick Edit from core is blocked on an official contrib release to use as a replacement when we deprecate core quickedit in 9.4.x.
Proposed resolution
Subtree split the core/modules/quickedit directory into a 1.0.x branch of this contrib project.
Cut a 1.0.0 release.
Remaining tasks
Try the 1.0.0-rc1 release on real D9 or D10 sites and make sure it does what it needs.Mostly.Are any of core's composer dependencies things that quickedit should declare as its own dependencies?=> #3263769: Properly declare external dependencies- Any bugs that should block a 1.0.0 stable release?
- #3260707: QuickEditJavascriptTestBase must be declared abstract
- #3261096: Include quickedit plugins from editor and image modules
- #3261254: Failing test Drupal\Tests\quickedit\FunctionalJavascript\SettingsTrayIntegrationTest::testQuickEditLinks
- #3263768: quickedit.icons.theme.css using core-relative paths that are no longer valid: missing icons, broken UI
- Actually tag 1.0.0 and make a release for it
Comments
Comment #2
dwwAnyone willing to try the 1.0.0-rc1 release on real D9 or D10 sites and make sure it does what it needs?
Are any of core's composer dependencies things that quickedit should declare as its own dependencies?
Any bugs that should block a 1.0.0 stable release?
Thanks!
-Derek
Comment #3
dww#3261096: Include quickedit plugins from editor and image modules was almost the last blocker, until I did some local testing and noticed #3263768: quickedit.icons.theme.css using core-relative paths that are no longer valid: missing icons, broken UI.
Comment #4
dwwSplit off #3263769: Properly declare external dependencies to its own child issue to be easier to track and resolve.
Comment #6
dww#3263768: quickedit.icons.theme.css using core-relative paths that are no longer valid: missing icons, broken UI is now done. 🎉
Found one other minor problem, but decided to just push the fix directly as part of this issue.
#3263769: Properly declare external dependencies is all that's left.
Would still welcome some manual testing from anyone else who's so inspired. My attempts have been very fruitful.
Comment #7
dwwMy manual testing helped a lot, removing that tag. 😉
Based on https://www.drupal.org/files/issues/2022-02-10/3263769-3.slack_.txt @xjm and I decided not to block 1.0.0 on #3263769: Properly declare external dependencies
Presenting https://www.drupal.org/project/quickedit/releases/1.0.0