After switching to PHP8 appeared notice "Deprecated: Required parameter $node follows optional parameter $account in /workbench_moderation.module on line 1657"

CommentFileSizeAuthor
#3 workbench_moderation-3259574-php-8.0-compatibility.patch600 bytesPavel_SPN
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavel_SPN created an issue. See original summary.

Pavel_SPN’s picture

Pavel_SPN CreditAttribution: Pavel_SPN at EPAM Systems commented
Issue summary: View changes

I propose just remove "= NULL" for the $account because below in the code there is a check for this variable:

  if (empty($account)) {
    $account = $GLOBALS['user'];
  }
Pavel_SPN’s picture

Pavel_SPN CreditAttribution: Pavel_SPN at EPAM Systems commented
FileSize
workbench_moderation-3259574-php-8.0-compatibility.patch600 bytes
Pavel_SPN’s picture

Pavel_SPN CreditAttribution: Pavel_SPN at EPAM Systems commented
Issue summary: View changes
poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented

I think the patch looks good, thanks!

poker10’s picture

poker10 CreditAttribution: poker10 at ActivIT s.r.o. commented
Status: Needs review » Reviewed & tested by the community
Alina Basarabeanu’s picture

Alina Basarabeanu CreditAttribution: Alina Basarabeanu at Cyber-Duck commented

Patch #3 works on Drupal core 7.91, PHP 8.0.21 and Workbench Moderation 7.x-3.0 version
Is there any chance to get merged into dev or a new stable release for Drupal 7?

peezy’s picture

peezy CreditAttribution: peezy as a volunteer and at Acquia commented

I can confirm that #3 is working on PHP 8.0 and Drupal 7.98 as well.

anrikun’s picture

anrikun CreditAttribution: anrikun commented

+1 for patch #3