Problem/Motivation

On IE11, the javascript added in #3224465: Improve accessibility of help buttons https://www.drupal.org/project/webform/issues/3224465 breaks.

Steps to reproduce

On a clean install, add a new webform with a field containing a "Help text". Open the webform on IE11.

The error that we have is:
```
SCRIPT1003: expected: ':'
webform.element.help.js (32, 11)
```

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork webform-3257966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mathilde_dumond created an issue. See original summary.

mathilde_dumond’s picture

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented
Issue summary: View changes

jrockowitz made their first commit to this issue’s fork.

jrockowitz opened merge request !128

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review

Yep, that change introduced some ES6 code. Once Drupal 10 is released with drop IE11 support. For now, I backported the code snippet to ES5 using https://babeljs.io/repl/

  • jrockowitz committed cd2d32c on 6.1.x 
    Issue #3257966 by jrockowitz: hideonesc plugin does not work on IE11
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Fixed

Since the code change is automated, I merged the PR, Please try the patch or download the latest dev release to test.

mathilde_dumond’s picture

mathilde_dumond CreditAttribution: mathilde_dumond at MD Systems GmbH commented

Applied the patch and it fixed the issue, thanks a lot!

  • jrockowitz committed cd2d32c on 6.x 
    Issue #3257966 by jrockowitz: hideonesc plugin does not work on IE11

  • jrockowitz committed cd2d32c on 6.2.x 
    Issue #3257966 by jrockowitz: hideonesc plugin does not work on IE11

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.