Problem/Motivation

As of 8.8.x, modules can declare their Drupal 8 (or 9) upgrade status (changelog, issue #2936365: Migrate UI - allow modules to declare the state of their migrations).

As of captcha-8.x-1.2, this module appears to have a complete (finished) upgrade path from D7 (I have tested the D7 upgrade, it works excellently) but not D6.

Proposed resolution

Declare the finished upgrade path from D7 and the not_finished upgrade path from D6 by creating a migrations/state/captcha.migrate_drupal.yml and populating it appropriately.

Remaining tasks

  1. Write a patch
  2. Review and feedback
  3. RTBC and feedback
  4. Commit
  5. Release

User interface changes

None.

API changes

None.

Data model changes

None.

Comments

mparker17 created an issue. See original summary.

mparker17’s picture

Issue summary: View changes

D6 does not have an upgrade yet; updating summary.

mparker17’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.84 KB

Here's a patch. Reviews welcome!

mparker17’s picture

StatusFileSize
new1.84 KB

And, apparently I failed at naming that patch.

Here's the same patch with the new comment number and the correct extension to make testbot pay attention to it. No interdiff because it's the same patch.

Thanks for your patience with me; it's been a long day.

Status: Needs review » Needs work

The last submitted patch, 4: 3256490-4--declare-upgrade-status.patch, failed testing. View results

mparker17’s picture

Status: Needs work » Needs review
StatusFileSize
new1.84 KB
new511 bytes

Oops, the list of modules in a test is supposed to be protected in D9.

Status: Needs review » Needs work

The last submitted patch, 6: 3256490-6--declare-upgrade-status.patch, failed testing. View results

mparker17’s picture

Status: Needs work » Needs review
StatusFileSize
new670 bytes
new1.04 KB

I don't know why that test is failing; but not all core/contrib modules test the declared migration state, so I daresay it's safe for us to also not test it.

japerry’s picture

Status: Needs review » Fixed

I agree, just getting the yml file in there would be helpful. We can follow up with more migration improvements later.

  • japerry committed 2e3412b on 8.x-1.x authored by mparker17
    Issue #3256490 by mparker17: Declare upgrade status from D6, D7
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.