Not expected behavior from the pager.
Given that the
"Project Browser"module was installed under Drupal 9.2.x
And logged in as the"webmaster"user no. 1
When navigating to"/admin/modules/browse"
And check the"Accessibility"from"Categories"
Then the "28 projects" shows up under the pager with"3"pager links
When clicking on"3"pager link
Then the last"4"projects out of"28"will show up in the page
But the"Next"and"Last"will still show up in the pager too
When clicking"Next"or"Last"
Then the page will load"No records available"
And the"First","Previous","Next","Last"will still show up in the empty projects page.
More integrations for the pager web component to inline with Drupal core logic.
| Comment | File | Size | Author |
|---|---|---|---|
| project_browser--pager--wrong-next--or-last-pager-link.png | 58.47 KB | rajab natshah | |
| project_browser--pager.png | 83.07 KB | rajab natshah |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
rajab natshahComment #3
rajab natshahComment #4
rajab natshahComment #5
chrisfromredfinComment #7
tim.plunkett# of projects changed since then, but the bug is still a problem.
This should be testable.
Comment #9
tim.plunkettTests added. Had to adjust the fixture a bit to get exactly 12 or 24 projects on a page at once, but chose the least invasive change (adding one category to one project).
Comment #10
fjgarlin commentedComment #11
fjgarlin commentedClicking through pages returns now the expected results, with no overlapping and the expected results in the last page.
But I found a couple of pagination-related bugs:
* When you are in the last page, if you click "Next" or "Last", you get 0 results. ie: Filter by "Accessibility" and navigate to page 7, then click on either "next" or "last".
* When you are viewing results, if you click on "Last", you get 0 results. ie: Reload the page and click on "last".
Comment #12
tim.plunkettGood catch! Realized that sometimes it's 0-indexed and others it's 1-indexed. Standardized on 0-indexed to reduce total changes, and adjusted the tests
Comment #13
fjgarlin commentedRe-tested again and it all works as expected, including the cases mentioned above.
The tests come up green (including the newly added ones) and the code looks good.
Marking RTBC. Thanks!
Comment #14
bnjmnmI see now how this was difficult to reproduce! The calculation determining the number of pages got messed up when the total was a multiple of the items-per-page because the
total/perPagewould be a whole number soMath.floor()wouldn't do the necessary -1. The solution elegantly addresses that, and the additional test coverage confirms it to be the case.