Problem/Motivation

Refer to https://www.drupal.org/project/leaflet/issues/3236815 suggestion, in order to make use of GeoField proximity filtering and ordering, a meaningful "Origin Coordinates" for end-user is important, e.g.:

  1. A manual default origin coordinate
  2. Center of map after end-user moving the map by mouse click-and-move
  3. The client location through the browser HTML5 Geolocation API (e.g. by GPS, IP, etc)

This PR add support for Leaflet with Geolocation functionality, by introduce https://github.com/domoritz/leaflet-locatecontrol integration.

Issue fork leaflet-3252629

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hswong3i created an issue. See original summary.

hswong3i opened merge request !6

hswong3i’s picture

hswong3i commented
Status: Active » Needs review
hswong3i’s picture

hswong3i commented
Parent issue: » #3236815: Add more helpful options for views proximity filter
Related issues: -#3236815: Add more helpful options for views proximity filter
hswong3i’s picture

hswong3i commented
Parent issue: #3236815: Add more helpful options for views proximity filter » #2942651: Manage Leaflet library dependency with Composer & Asset Packagist
Related issues: +#3236815: Add more helpful options for views proximity filter
hswong3i’s picture

hswong3i commented
Version: 2.1.x-dev » 3.0.x-dev

  • hswong3i committed 76aa917 on 3.0.x 
    Issue #3252629 by hswong3i: Add domoritz/leaflet-locatecontrol Support...

  • itamair committed 4afea8b on 3.0.x 
    Revert "Issue #3252629 by hswong3i: Add domoritz/leaflet-locatecontrol...
itamair’s picture

itamair commented

This cannot be approved as it is based on the 3.0.x-dev branch that is only experimental and not being supported now, in the short & mid term, because it doesn't provide a smooth and automatic upgrade path for all the 2.x users.

All this features requests should be also smoothly applicable to the 2.x branch, with full BW compatibility into it and upgrade/update path, to be approved ...

itamair’s picture

itamair commented
Status: Needs review » Needs work

itamair closed merge request !6

itamair’s picture

itamair commented
Status: Needs work » Closed (outdated)