Problem/Motivation

Previous related issues: #3213295: Update Symfony 5 components to 5.3-rc1 and #3216088: Update Symfony 5 components to 5.3.

Our 4-5 Symfony 5 components currently are on 5.3 versions, but Symfony 5.4 will be released prior to 9.3.0, which means that Symfony 5.3 will lose security coverage before 9.3.

Proposed resolution

We need to update our Symfony 5 dependencies to a 5.4 beta or RC as soon as possible, and to 5.4.0 prior to 9.3.0.

API changes

TBD

Data model changes

N/A

Release notes snippet

Needed

CommentFileSizeAuthor
#9 3249233-9.patch15.34 KBlongwave
#5 3249233-5.patch15.49 KBlongwave
#2 3249233.patch11.01 KBlongwave

Comments

xjm created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new11.01 KB
+--------------------+---------+--------------+
| Production Changes | From    | To           |
+--------------------+---------+--------------+
| symfony/mime       | v5.3.8  | v5.4.0-BETA1 |
| symfony/var-dumper | v5.3.10 | v5.4.0-BETA1 |
+--------------------+---------+--------------+

+------------------------+---------+--------------+
| Dev Changes            | From    | To           |
+------------------------+---------+--------------+
| symfony/phpunit-bridge | v5.3.10 | v5.4.0-BETA1 |
+------------------------+---------+--------------+

Given Symfony's release history I would expect 5.4.0-rc1 within the next 7 days and Symfony 5.4.0 on or just before 30th November.

andypost’s picture

There's more updates to composer, for beta2 (next week) it needs follow-up

+------------------------+-------+-------+
| Production Changes     | From  | To    |
+------------------------+-------+-------+
| laminas/laminas-stdlib | 3.6.0 | 3.6.1 |
+------------------------+-------+-------+

+--------------------+-------+-------+
| Dev Changes        | From  | To    |
+--------------------+-------+-------+
| sebastian/exporter | 3.1.3 | 3.1.4 |
+--------------------+-------+-------+

Status: Needs review » Needs work

The last submitted patch, 2: 3249233.patch, failed testing. View results

longwave’s picture

Status: Needs work » Needs review
StatusFileSize
new15.49 KB

Fixed test failure and addressed #3

+------------------------+---------+--------------+
| Production Changes     | From    | To           |
+------------------------+---------+--------------+
| laminas/laminas-stdlib | 3.6.0   | 3.6.1        |
| symfony/mime           | v5.3.8  | v5.4.0-BETA1 |
| symfony/var-dumper     | v5.3.10 | v5.4.0-BETA1 |
+------------------------+---------+--------------+

+------------------------+---------+--------------+
| Dev Changes            | From    | To           |
+------------------------+---------+--------------+
| sebastian/exporter     | 3.1.3   | 3.1.4        |
| symfony/phpunit-bridge | v5.3.10 | v5.4.0-BETA1 |
+------------------------+---------+--------------+
daffie’s picture

Status: Needs review » Reviewed & tested by the community

This only update the Symfony components to 5.4-beta1. We shall need a followup getting it to full version.

andypost’s picture

catch’s picture

Status: Reviewed & tested by the community » Needs work

Let's get this in with beta2 now it's released so we only have to update from there.

longwave’s picture

Status: Needs work » Needs review
StatusFileSize
new15.34 KB
+------------------------+---------+--------------+
| Production Changes     | From    | To           |
+------------------------+---------+--------------+
| laminas/laminas-stdlib | 3.6.0   | 3.6.1        |
| symfony/mime           | v5.3.8  | v5.4.0-BETA1 |
| symfony/var-dumper     | v5.3.10 | v5.4.0-BETA2 |
+------------------------+---------+--------------+

+------------------------+---------+--------------+
| Dev Changes            | From    | To           |
+------------------------+---------+--------------+
| sebastian/exporter     | 3.1.3   | 3.1.4        |
| symfony/phpunit-bridge | v5.3.10 | v5.4.0-BETA2 |
+------------------------+---------+--------------+

symfony/mime had no changes between beta1 and beta2 so there is no new tag: https://packagist.org/packages/symfony/mime

catch’s picture

Status: Needs review » Reviewed & tested by the community

Patch includes a couple of patch-level updates for other dependencies but fine to include I think.

  • larowlan committed bcf1456 on 9.4.x
    Issue #3249233 by longwave: Update 9.3's Symfony 5 components to 5.4
    

  • larowlan committed 910dedc on 9.3.x
    Issue #3249233 by longwave: Update 9.3's Symfony 5 components to 5.4
    
    (...
larowlan’s picture

Status: Reviewed & tested by the community » Fixed
+++ b/core/tests/Drupal/BuildTests/Composer/Template/ComposerProjectTemplatesTest.php
@@ -32,7 +32,7 @@ class ComposerProjectTemplatesTest extends BuildTestBase {
-  protected const MINIMUM_STABILITY = 'stable';
+  protected const MINIMUM_STABILITY = 'beta';

Can we get a follow-up critical against 9.3.x to move this back and update to the 5.4.x stable versions - thanks - as asked by @daffie in #6 too.

Committed bcf1456 and pushed to 9.4.x.

Backported to 9.3.x

Thanks

larowlan’s picture

xjm’s picture

Issue tags: +9.3.0 release notes

Please always tag dep update issues for the release notes.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.