Update Symfony 5 components to 5.3

hopefully before we get to 9.2.0

https://symfony.com/blog/a-week-of-symfony-751-17-23-may-2021 claims "final release at the end of this month", so if they're still on track with that, it should be by Monday.

Historically Symfony x.y.0 releases are almost always the last day or two of May and November, so I also expect it on Sunday or Monday.

https://symfony.com/blog/symfony-5-3-0-released is out!

FWIW: diff from MR applies cleanly on 9.2.x

Applied the diff, removed vendor, and got the expected result with composer install, so this is ready to go assuming tests pass.

Hereʻs the diff as a file attachment so we can see the test results against 9.2.x.

Need to bump the new stability constant in Drupal\BuildTests\Composer\Template\ComposerProjectTemplatesTest from RC to stable, as all our dependencies are now stable.

#11 failed with:

1) Drupal\BuildTests\Composer\Template\ComposerProjectTemplatesTest::testMinimumStabilityStrictness
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'stable'
+'RC'

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121

Need to bump the new stability constant in Drupal\BuildTests\Composer\Template\ComposerProjectTemplatesTest from RC to stable, as all our dependencies are now stable.

Are we seriously going to be doing this every minor? I think we need a followup to come up with a better solution for that test.

Ah, crosspost before the D9.3 test stumbled over the fact that we are now too loose on the MINIMUM_STABILITY, since we don't require RC's anymore.

Upped that to stable as it was before.

EDIT: Crossposted with the previous crosspost whilst talking about crossposting.

Diff from MR against 9.2.x

Looks OK to me.

@xjm in #14

Are we seriously going to be doing this every minor? I think we need a followup to come up with a better solution for that test.

"Every minor" seems to be every Symfony minor, which happens twice a year.

Personally I rather curse four times a year (once for needing to loosen and once for needing to tighten per minor release) because I forgot to BLEEP-ing change the MINIMUM_STABILITY than having a too loose restriction.
All it takes is a failing test to remind us we forgot, which is exactly what happens here.

I don't see the need for a follow-up, but that might be just me.

Are we seriously going to be doing this every minor?

Only when we commit a dependency update that's intentionally less stable than that constant, and then again when we commit an update that allows us to re-raise the constant. It's already a manual process to create a patch with those dependency updates to begin with, does changing the constant in the same patch add much overhead?

Pushed to 9.3.x and 9.2.x. I'll open the followup shortly.

Here's the followup: #3216787: Consider alternatives to the ComposerProjectTemplatesTest::MINIMUM_STABILITY constant

FYI https://github.com/symfony/symfony/releases/tag/v5.3.1

Thanks for surfacing that! Doesn't look like 5.3.1 includes any changes to the components we're using. They're not listed in the changelog of the link in #27, and when I run composer update drupal/core symfony/mime symfony/var-dumper symfony/phpunit-bridge locally, nothing gets updated.

If someone discovers otherwise, please add another comment here, so that we can make sure to update.

Yes, looks only upgrade to 4.4.25 make sense because of DependencyInjection but it could wait for 9.2.1

Yep, the patch-level update can, but there are some minor-level updates that we need to decide if/when they make it into 9.2.x: #3217315: Update non-dev dependencies to latest minor as of June 3, 2021.

For Symfony 4.4.25, I also opened #3217320: Update dependencies to latest patch-level releases as of June 3, 2021, whether we decide to get that in before 9.2.0 or after.