Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Follow-up from #3213295: Update Symfony 5 components to 5.3-rc1. As soon as Symfony releases, and hopefully before we get to 9.2.0, we should update from the rc to stable releases.
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#17 | 742[1].diff | 10.11 KB | Spokje |
Issue fork drupal-3216088
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
effulgentsia CreditAttribution: effulgentsia at Acquia commentedhttps://symfony.com/blog/a-week-of-symfony-751-17-23-may-2021 claims "final release at the end of this month", so if they're still on track with that, it should be by Monday.
Comment #3
longwaveHistorically Symfony x.y.0 releases are almost always the last day or two of May and November, so I also expect it on Sunday or Monday.
Comment #4
Gábor Hojtsyhttps://symfony.com/blog/symfony-5-3-0-released is out!
Comment #6
SpokjeComment #10
SpokjeComment #11
SpokjeFWIW: diff from MR applies cleanly on
9.2.x
Comment #12
xjmApplied the diff, removed vendor, and got the expected result with
composer install
, so this is ready to go assuming tests pass.Hereʻs the diff as a file attachment so we can see the test results against 9.2.x.
Comment #13
longwaveNeed to bump the new stability constant in Drupal\BuildTests\Composer\Template\ComposerProjectTemplatesTest from RC to stable, as all our dependencies are now stable.
Comment #14
xjm#11 failed with:
Are we seriously going to be doing this every minor? I think we need a followup to come up with a better solution for that test.
Comment #15
SpokjeAh, crosspost before the D9.3 test stumbled over the fact that we are now too loose on the MINIMUM_STABILITY, since we don't require RC's anymore.
Upped that to
stable
as it was before.EDIT: Crossposted with the previous crosspost whilst talking about crossposting.
Comment #17
SpokjeDiff from MR against
9.2.x
Comment #18
SpokjeComment #19
longwaveLooks OK to me.
Comment #20
Spokje@xjm in #14
"Every minor" seems to be every Symfony minor, which happens twice a year.
Personally I rather curse four times a year (once for needing to loosen and once for needing to tighten per minor release) because I forgot to BLEEP-ing change the
MINIMUM_STABILITY
than having a too loose restriction.All it takes is a failing test to remind us we forgot, which is exactly what happens here.
I don't see the need for a follow-up, but that might be just me.
Comment #21
effulgentsia CreditAttribution: effulgentsia at Acquia commentedOnly when we commit a dependency update that's intentionally less stable than that constant, and then again when we commit an update that allows us to re-raise the constant. It's already a manual process to create a patch with those dependency updates to begin with, does changing the constant in the same patch add much overhead?
Comment #24
effulgentsia CreditAttribution: effulgentsia at Acquia commentedPushed to 9.3.x and 9.2.x. I'll open the followup shortly.
Comment #26
effulgentsia CreditAttribution: effulgentsia at Acquia commentedHere's the followup: #3216787: Consider alternatives to the ComposerProjectTemplatesTest::MINIMUM_STABILITY constant
Comment #27
andypostFYI https://github.com/symfony/symfony/releases/tag/v5.3.1
Comment #28
effulgentsia CreditAttribution: effulgentsia at Acquia commentedThanks for surfacing that! Doesn't look like 5.3.1 includes any changes to the components we're using. They're not listed in the changelog of the link in #27, and when I run
composer update drupal/core symfony/mime symfony/var-dumper symfony/phpunit-bridge
locally, nothing gets updated.If someone discovers otherwise, please add another comment here, so that we can make sure to update.
Comment #29
andypostYes, looks only upgrade to 4.4.25 make sense because of DependencyInjection but it could wait for 9.2.1
Comment #30
effulgentsia CreditAttribution: effulgentsia at Acquia commentedYep, the patch-level update can, but there are some minor-level updates that we need to decide if/when they make it into 9.2.x: #3217315: Update non-dev dependencies to latest minor as of June 3, 2021.
Comment #31
effulgentsia CreditAttribution: effulgentsia at Acquia commentedFor Symfony 4.4.25, I also opened #3217320: Update dependencies to latest patch-level releases as of June 3, 2021, whether we decide to get that in before 9.2.0 or after.