Problem/Motivation

Upon clicking 'Save configuration' button, the page does not report whether the settings has been saved successfully or not.

Steps to reproduce

  1. Navigate to /admin/config/system/gtm
  2. Make some modifications to settings (optional)
  3. Click 'Save configuration'
CommentFileSizeAuthor
#7 gtm.png635.66 KBmohit.bansal623

Issue fork gtm-3242888

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

marlon.buella created an issue. See original summary.

marlon.buella’s picture

marlon.buella CreditAttribution: marlon.buella as a volunteer commented

The fix will be adding just the call to submitForm function of the parent class (Drupal\Core\Form\ConfigFormBase) inside the submitForm function in order to display the default save message.

parent::submitForm($form, $form_state);

marlon.buella opened merge request !3

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: avpaderno as a volunteer commented
Version: 8.x-1.6 » 8.x-1.x-dev
marlon.buella’s picture

marlon.buella CreditAttribution: marlon.buella as a volunteer commented
Title: No status message displayed upon saving settings code. » No status message displayed upon saving settings form.
mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented

Is there anything left in this issue? I can see the merge request raised already.

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented
StatusFileSize
new gtm.png635.66 KB

The changes in merge request are correct. I have verified. Attaching screenshot.

mohit.bansal623’s picture

mohit.bansal623 CreditAttribution: mohit.bansal623 as a volunteer and at Axelerant commented
Status: Active » Needs review
marlon.buella’s picture

marlon.buella CreditAttribution: marlon.buella as a volunteer commented

There's no more left on my side, the status message 'The configuration options have been saved.' seems okay with me.

apolitsin’s picture

apolitsin CreditAttribution: apolitsin commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.