Problem/Motivation

The messages about Internet Explorer 11 are a bit unclear and confusing:

  • The messages say IE11 is not supported, but this might seem to imply to the end user (who doesn't know our browser support policy) that other versions of IE might be supported.
  • The phrase "the benefits of CKEditor" is vague and undefined.
  • Directly addressing users as "Internet Explorer 11 user:" is weird.
  • We only link the supported browser list in one place whereas supported browsers are mentioned twice.
  • The messages as they stand will be inaccurate in Drupal 10 since IE11 isn't itself a supported browser then. We can change the wording a little so that these messages aren't quite as out of place in D10 (although we should still have a followup to correct the text in D10).

Proposed resolution

Improve the messages.

Remaining tasks

Followup issue to simplify the messages further in D10.

User interface changes

Changed messages when configuring CKEditor and when using IE11 on a page where CKEditor is loaded.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#19 3232550-19-10.0.x.patch6.08 KBwim leers
#19 3232550-19.patch5.85 KBwim leers
#18 3232550-18.patch5.84 KBravi.shankar
#2 ckeditor5-3232550-2.patch3.14 KBxjm

Issue fork drupal-3232550

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new ckeditor5-3232550-2.patch3.14 KB
yash.rode’s picture

yash.rode commented

i have reviewed the new messages and they are more accurate now.

yash.rode’s picture

yash.rode commented
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Followup issue to simplify the messages further in D10.

To … remove it, I think you mean? Since D10 won't support IE11?

xjm’s picture

xjm
she/her
Primary language English
commented

No, to simplify them and say IE11 is not supported. We should still inform the user. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Per https://www.drupal.org/node/3199540, Drupal 10 is dropping IE11 support.

You're saying that despite that, we should be warning the site builder. Are we going to be sprinkling warnings like this everywhere in the UI?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Project: CKEditor 5 » Drupal core
Version: 1.0.x-dev » 9.3.x-dev
Component: Code » ckeditor5.module
quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Patch no longer applies :-(

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@lauriii clarified my confusing comments on this issue in a private chat — let me just quote him to get this issue back on the rails publicly! :D

Basically, I'm saying:

  1. The messages this patch is updating are specific to Drupal 9, because everything else in Drupal 9 does support IE11.
  2. Therefore we should be able to remove those messages in Drupal 10. So in #5, I simply challenged the need for a follow-up that clarifies those messages. If anything, the only follow-up this needs is to remove this message from Drupal 10 altogether!

This patch here is RTBC (as soon as it's green), but we still need @xjm's confirmation that we don't need a follow-up to clarify the messages further.

hooroomoo made their first commit to this issue’s fork.

hooroomoo opened merge request !1686

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » xjm
Status: Needs work » Needs review
Issue tags: +Needs release manager review

Great — the MR looks fine!

But we still need @xjm's confirmation per #11.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: xjm » Unassigned
Issue tags: -Needs release manager review

Thanks @Wim Leers. I think the D10 version of this if any is out of scope for this issue. I don't think filing a followup is a hard blocker for this, nor a stable blocker for CKE5. Retaining the messages seems harmless to me, but either way it's not blocking here. :) Up to you if you want to file it. Certainly doesn't need RM signoff either way.

I can't RTBC this since I wrote the original patch, so unassigning. Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs followup
Related issues: +#3261585: Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway

Follow-up created to remove it: #3261585: Remove IE11 warning for CKEditor 5 in Drupal 10, since Drupal 10 does not support IE anyway.

RTBC!

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs work

This needs a Drupal 10 patch.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3232550-18.patch5.84 KB

Added patch for Drupal 10.0.x.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3232550-19.patch5.85 KB
new 3232550-19-10.0.x.patch6.08 KB

Ah, yes, once again #3253148: Remove IE from core's browserlist, remove non-essential CSS importing and recompile assets is making this painful :| I really wish we'd done that issue later, that'd have made CKE5 work far less painful.

But we'll make it work! :)

EDIT: gahh, d.o cross-post-file-upload bug biting me again…

  • lauriii committed 105b60a on 10.0.x 
    Issue #3232550 by Wim Leers, hooroomoo, xjm, ravi.shankar: Improve...

  • lauriii committed 3744d21 on 9.4.x 
    Issue #3232550 by Wim Leers, hooroomoo, xjm, ravi.shankar: Improve...

  • lauriii committed c8d6a73 on 9.3.x 
    Issue #3232550 by Wim Leers, hooroomoo, xjm, ravi.shankar: Improve...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed patch from #18 105b60a and pushed to 10.0.x. Also committed 9.4.x patch from #19 to 9.4.x and cherry-picked to 9.3.x because CKEditor 5 is experimental. Thanks!

lauriii closed merge request !1686

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.