Closed (fixed)
Project:
Drupal core
Version:
10.0.x-dev
Component:
ckeditor5.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
31 Jan 2022 at 16:58 UTC
Updated:
5 Apr 2022 at 11:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
wim leers#3232550: Improve messaging about Internet Explorer 11 landed.
Comment #3
longwaveComment #4
longwaveComment #5
wim leersThat looks … very thorough :D
This is RTBC IMHO.
But … I'd rather not get this committed immediately, because it will likely make the work on CKEditor 5 even more painful. We already need to target 3 branches, and frequently need to provide a different patch for the D10 branch. This will make that necessary more often.
As soon as this is green, I'm marking this "postponed" again and will RTBC in ~1.5 month.
Thanks so much, @longwave!
Comment #7
wim leers3 weeks later, many things that were in progress have landed.
I now think we can totally do this now, especially because it makes it clearer that #3260032: CKEditor 5 adds ie11.user.warnings library to every page, triggering a FOUC even for anonymous users only impacts Drupal 9.3 and 9.4.
Do you want to reroll and get this to green, @longwave? :)
Comment #8
longwaveRerolled, also removed a bit too much in
ckeditor5_library_info_alter().Comment #9
wim leersThat looks perfect to me :)
Comment #10
catchNeeds another re-roll.
Comment #11
longwave#3266310: IE11 user warning has ungraceful failures landed in 10.0.x which updated ie11.user.warnings.es6.js and .js - both files are outright removed here so back to RTBC.
Comment #12
catchNeeds another re-roll...
Comment #13
ankithashettyHere is a rerolled patch, thanks!
Comment #15
longwaveMissed one line in ckeditor5.libraries.yml.
Comment #16
wim leersLooks just as good as when I RTBC'd it in #9 🤓
Comment #17
catchComment #18
wim leersSorry, @longwave 😬
Comment #19
longwaveClashed with #3270108: Editor does not load when using Edge + WHCM, rerolled and back to RTBC.
Comment #21
catchRare example of a js patch I'm comfortable committing ;)