Problem/Motivation

In preparation for #2158943: Add a native dialog element using HTMX to deprecate the jQuery UI dialog, we should have core equivalents of jQuery UI's dialog tests. This way, we can insure the shimmed dialog continues to pass tests.

This is similar to the tests added in #3076171: Provide a new library to replace jQuery UI autocomplete

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#9 3230046-nr-bot.txt150 bytesneeds-review-queue-bot

Issue fork drupal-3230046

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

larowlan’s picture

Should we be looking at something like https://github.com/testing-library/dom-testing-library here instead of nightwatch if we're releasing unit tests
This plus jest are the js equivalent of our kernel tests

lauriii made their first commit to this issue’s fork.

bnjmnm’s picture

Status: Active » Needs review

All tests are ported with the exception of #8051 - 'Explode' dialog animation causes crash in IE 6, 7 and 8 as it is targeted at browsers not supported by Drupal core.

A day after the final test was written, I did a final comparison against the jQuery UI Qunit tests to confirm everything was ported, and added assertion count checks for additional assurance (and these did surface a few incomplete tests that have since been addressed).

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

Status: Needs review » Needs work
StatusFileSize
new150 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

cosmicdreams’s picture

@bnjmnm what a wonderful collection of work here. As someone who has struggled to write Nightwatch tests it would be awesome if you could break down the architecture of the test module you wrote for this. Just walking through the test module is helpful but I don't think I understand everything I need to about it. A walkthrough / blog post would be super helpful.

In regard to this issue, despite the time since the test cases were written, the work appears to be mergable if rebased. Perhaps we should discuss what the next steps here are?

Is there anything left to do?

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.