Problem/Motivation

I've created a Tour that needs to show tips on blocks rendered via BigPipe and on elements that are not rendered via BigPipe. The tips that are on the elements that are rendered via BigPipe are not shown, the "normal" ones are.

Steps to reproduce

Create a tour, add tips for elements rendered with and without BigPipe. Start the tour.

Is there anyone else having this issue, or is there a fix for this issue?

CommentFileSizeAuthor
#13 3229595-13.patch2.83 KBmistrae
#7 3229595-7.patch4.63 KBgauravvvv
#7 interdiff-3229595-5_7.txt3.12 KBgauravvvv

Issue fork drupal-3229595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Issue fork tour-3229595

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fabianderijk created an issue. See original summary.

arjenk’s picture

arjenk commented

I had the same issue and solved it by removing the function _removeIrrelevantTourItems() from js/tour.js.

This function "* Removes tour items for elements that don't have matching page elements.". Now i dont know why it should do that, by disabling the function, the tip is shown, but centered and not pointing to a specific element. From a developer standpoint that makes more sense then to remove the tip. (Not to mention that it breaks valid tips when bigpipe is enabled)

There is a second purpose of this function: "* Or that are explicitly filtered out via the 'tips' query string.". Now this seems to me a more valid use-case.

So i would propose to refactor this function to not remove the tips that 'don't have matching page elements', and leave the second use-case.

Any other opinions?

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented

Thanks for debugging this a little further. I will see if I can come up with a solution for this and create a patch.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.1.10 (June 4, 2021) and Drupal 9.2.10 (November 24, 2021) were the last bugfix releases of those minor version series. Drupal 9 bug reports should be targeted for the 9.3.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

fabianderijk opened merge request !1688

fabianderijk’s picture

fabianderijk
him/his
Primary language Dutch
Location Alphen aan den Rijn
commented
Status: Active » Needs review

I've just created the MR that removes the function.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new interdiff-3229595-5_7.txt3.12 KB
new 3229595-7.patch4.63 KB

Please right the js code in es6.js file then compile. I have rerolled the patch #5, and attached interdiff for same. Please review.

Status: Needs review » Needs work

The last submitted patch, 7: 3229595-7.patch, failed testing. View results

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

cilefen’s picture

cilefen commented
Category: Support request » Bug report
Issue tags: -Tour, -BigPipe

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Postponed

This extension is being deprecated, see #3336033: [Meta] Tasks to deprecate Tour module. It will be removed from core and moved to a contrib project, #3376099: [11.x] [Meta] Tasks to remove Tour.

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

mistrae’s picture

mistrae commented
Version: 9.5.x-dev » 10.2.x-dev
StatusFileSize
new 3229595-13.patch2.83 KB

Patch for core version 10 is anyone is interested

Version: 10.2.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Project: Drupal core » Tour
Version: 11.x-dev » 1.0.x-dev
Component: tour.module » Code
Status: Postponed » Needs work
smustgrave’s picture

smustgrave commented
Version: 1.0.x-dev » 2.0.x-dev

Instead of removing this wonder if we can do a lazybuilder like announcement_feeds does.

smustgrave opened merge request !15

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

Someone mind testing this solution out?

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Will be included in 2.x alpha1 release

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.