Add opttions for Remove Advanced and Target Tabs in CKEditor

Thanks Sinduri!

I think this is not the correct approach. I just tested the settings in wysiwyg_ckeditor_settings():

'linkShowAdvancedTab' => FALSE,
'linkShowTargetTab' => FALSE,

And the 2 tabs get hidden correctly with ckeditor 4.x.

So it would be the best if we make config options for the link plugin in wysiwyg_ckeditor_settings_form(), then users can configure those 2 options in their editor profile?

Thank you, this approach also works for me! Found some small problems:

1. +++ b/editors/ckeditor.inc
   @@ -233,6 +233,8 @@ function wysiwyg_ckeditor_settings_form(&$form, &$form_state) {
   +    'linkShowAdvancedTab' => FALSE,
   +    'linkShowTargetTab' => FALSE,
   

   I think we don't want to change the default behavior from before - they should be TRUE per default and then users can change the setting.

2. +++ b/editors/ckeditor.inc
   @@ -409,6 +411,30 @@ function wysiwyg_ckeditor_settings_form(&$form, &$form_state) {
   +    '#title' => t('Do not show advanced tab'),
   

   Thanks, but I think the logic is reversed: If I check the checkbox then the advanced tab is shown.

   Can we make this less confusing by avoiding negations?

   So use the name "Show advanced tab" - if it is checked then it should be shown. That also better matches the setting name "linkShowAdvancedTab". Same for the target tab.

Nice, looks good to me now!

Setting this to the dev version since it should be committed there.

I have created an MR . please merge thanks

Thanks all!