_termcase_vocabulary_termcase() function is not defined [#3227648]

It does not appear that the current 8.x-1.x-dev version is working with Drupal 9 yet.

Some problems that I've found:

Line 30 of termcase.module calls the non-existent "_termcase_vocabulary_termcase()" function.
Line 151 of termcase.module calls the deprecated "getVocabularyId()" method (should be "bundle()").

-mike

Comment	File	Size	Author
#3	3227648-2.patch	1.05 KB	Megha_kundar

Issue fork termcase-3227648

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3227648-termcasevocabularytermcase-function-is changes, plain diff MR !3
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 August 2021 at 07:48

ultimike created an issue. See original summary.

Comment #2

Megha_kundar CreditAttribution: Megha_kundar at Material for Drupal Association commented 11 August 2021 at 11:16

Assigned:

Unassigned

» Megha_kundar

Comment #3

Megha_kundar CreditAttribution: Megha_kundar at Material for Drupal Association commented 11 August 2021 at 13:46

Status:

Active

» Needs review

File	Size
3227648-2.patch	1.05 KB

Comment #4

Megha_kundar CreditAttribution: Megha_kundar at Material for Drupal Association commented 11 August 2021 at 13:46

Assigned:

Megha_kundar

» Unassigned

Comment #5

vikashsoni CreditAttribution: vikashsoni as a volunteer and at Zyxware Technologies commented 22 December 2021 at 09:41

@Megha_kundar Patch applied successfully
Thanks for the patch

Comment #6

dabley CreditAttribution: dabley commented 5 January 2022 at 23:26

Patch #3 works ok for me (with D9.3.2). It solves a problem we encountered after migrating to D9 (deprecated "getVocabularyId()" method).

Comment #7

dabley CreditAttribution: dabley commented 18 August 2022 at 19:32

I find that patch #3 no longer applies successfully to D9.4.5. This is because the changes to fix point (2) are now already present. (Issue #3259542: Call to undefined method Drupal\taxonomy\Entity\Term::getVocabularyId() in termcase_taxonomy_term_presave() (line 151 is a duplicate of this point.)

The definition of function "_termcase_vocabulary_termcase() (point (1)) is not present (without the patch). However, from a quick test, I was not able to find a use-case where the absence of this function causes a problem (i.e. it seems that function termcase_form_taxonomy_form_term_alter does not get called.).

Can anyone else find a scenario where point 1 causes a problem?

I suggest that this issue is flagged as "Fixed", because the module is now D9 compatible. If there's a problem with the _termcase_vocabulary_termcase function, then that's not a D9 compatibility matter, and a separate issue ought to be raised about that.