It does not appear that the current 8.x-1.x-dev version is working with Drupal 9 yet.

Some problems that I've found:

  1. Line 30 of termcase.module calls the non-existent "_termcase_vocabulary_termcase()" function.
  2. Line 151 of termcase.module calls the deprecated "getVocabularyId()" method (should be "bundle()").

-mike

CommentFileSizeAuthor
#3 3227648-2.patch1.05 KBmegha_kundar

Issue fork termcase-3227648

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ultimike created an issue. See original summary.

megha_kundar’s picture

megha_kundar commented
Assigned: Unassigned » megha_kundar
megha_kundar’s picture

megha_kundar commented
Status: Active » Needs review
StatusFileSize
new 3227648-2.patch1.05 KB
megha_kundar’s picture

megha_kundar commented
Assigned: megha_kundar » Unassigned
vikashsoni’s picture

vikashsoni commented

@Megha_kundar Patch applied successfully
Thanks for the patch

dabley’s picture

dabley commented

Patch #3 works ok for me (with D9.3.2). It solves a problem we encountered after migrating to D9 (deprecated "getVocabularyId()" method).

dabley’s picture

dabley commented

I find that patch #3 no longer applies successfully to D9.4.5. This is because the changes to fix point (2) are now already present. (Issue #3259542: Call to undefined method Drupal\taxonomy\Entity\Term::getVocabularyId() in termcase_taxonomy_term_presave() (line 151 is a duplicate of this point.)

The definition of function "_termcase_vocabulary_termcase() (point (1)) is not present (without the patch). However, from a quick test, I was not able to find a use-case where the absence of this function causes a problem (i.e. it seems that function termcase_form_taxonomy_form_term_alter does not get called.).

Can anyone else find a scenario where point 1 causes a problem?

I suggest that this issue is flagged as "Fixed", because the module is now D9 compatible. If there's a problem with the _termcase_vocabulary_termcase function, then that's not a D9 compatibility matter, and a separate issue ought to be raised about that.

dabley’s picture

dabley commented
Title: Drupal 9 compatibility issues » _termcase_vocabulary_termcase() function is not defined
Status: Needs review » Needs work

I've updated the issue title to reflect the outstanding problem more accurately.

dabley’s picture

dabley commented

AstonVictor made their first commit to this issue’s fork.

AstonVictor opened merge request !3

astonvictor’s picture

astonvictor commented
Status: Needs work » Fixed

thanks for the patch.

Merged it for now. other fixes will be added to other issues.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.