Only render the view title if the 'Include view title' plugin is enabled

Here is a patch to fix this issue. Added "Display view title" as default option. Also it's removed from the "Enable extra settings" section to avoid any misunderstandings.

Thanks for the pertinent remark!
We should make this things customizable as much as possible for comfortable work. You are absolutely right about these cases.
So, I tried to find a workaround for this. Made some changes according your comments.

Now we can choose different settings for the view title displaying.
First two option is pretty clear.
"Let users show or hide the view title" option provide possibility for the editors to choose show or hide View title.

Probably the main problem is that you should re-save node edit form to apply changes.

Thanks for your efforts!

I would expect changing the field setting to override any prior settings made by the user.

You are absolutely right. I'll check it out and fix it soon!

Fixed issues mentioned by John Pitcairn in the comment #8.
Seems to work fine now. Please check it out and let me know if you have some suggestions how we can improve this functionality.

Composer fails to merge patch in #11 against current dev. Attached patch fixes that.

Here's another updated patch for more updates in dev.

Hi Tried patch #15 but it did not work. In version 2.0 we don't have the option like 1.8 for the "Include View Title" on the specific content level.

Same problem as number #18, the option to deactivate the title does not appearSame problem as number 18, the option to deactivate the title does not appear

I recreated my patch based on #11, so the missing option should be there.

Here's patch #20 again, this time with the PHP CodeSniffer issues resolved.

Same problem here on 2.0.beta7, resolved by adding a title display settings verification (check also that your field formatter settings has always the title display option to false ), that worked for me.

Sorry I made a mistake during the previous patch generation. Please ignore it and try this one.

Hi daisyleroy, facing this issue: "$this" can no longer be used in a plain function or method since PHP 7.1 while applying patch #26 on this 2.0.beta7 version..

Updated the patch by fixing this issue: $this" can no longer be used in a plain function or method since PHP 7.1 now able to apply on 2.0.beta7..

There is some much deeper problem here, something is wrong with the functionality and storage of this option in 2.0-beta7

In the field settings, the title value can not be saved at all. I guess there is an incorrect schema:

viewsreference.schema.yml

field.field_settings.viewsreference:
  type: mapping
  label: 'Viewsreference field settings'
  mapping:
    enabled_settings:
      type: sequence
      label: 'Enabled settings'
      sequence:
        type: viewsreference.enabled_settings.[%key]

viewsreference.enabled_settings.title:
  type: boolean
  label: 'Include View Title settings'

However, in the field config we see this structure:

field.field.ENTITY.FIELDNAME.yml

settings:
  enabled_settings:
    argument: argument
    pager: pager
    title: true <--- this does not look correct here, I believe the value should be 'title' here

I also tried manually hacking the config value to 'title' and then importing, but the display title option still was not rendered in the form.

I tested patch #28 and it did not have any noticeable effect on my site, did not change anything.

#25 mentions a field formatter / display setting. This setting was visible one time. But after changing settings in the field storage, the "display title" option in the field formatter / display setting was gone forever (tried removing and re-patching, but the display option in the field formatter was lost). I also don't understand why a field formatter option is necessary at all, when this feature exposes that setting to the editor.

To me it seems all the patches miss the problem. In regard of title display:
- none of the patches here for 2.0-beta7 works
- 2.0-beta6 works
- using 2.0-beta7 without any of the patches here and simply manually deleting the schema file works

I'm closing this issue in favour of issue 3402036.

If you are using 2.0-beta7 and have problems with the views title display, use the patch the issue linked above.

The issue summary was quite a bit out of date as are earlier screenshots of the UI. I updated it to match the current state. Re-opening this as the current state still shows the view title view plugin regardless of whether the plugin is enabled or not. This is because this plugin is loaded differently compared to plugins that affect the view itself: this plugin is loaded above the render of the view with its own unique code to load it.

Patch doesn't work.

Patch should work now. Could you please confirm?
Test coverage also added.

So current situation with this MR is now:

1. 'Include the view title' plugin not enabled on the field: No title shown
2. 'Include the view title' plugin is enabled on the field: Checkbox unchecked: No title shown
3. 'Include the view title' plugin is enabled on the field: Checkbox checked: Title shown

Updated patch for the 8.x-2.0-beta10

Updated the merge request to merge in the latest 2.x changes.

Can't use a patch file generated from that with composer as it includes modifications to the tests directory contents which is actually specified in the .gitattributes file to export-ignore:

/tests export-ignore

So to use this currently (on beta10) (before this MR is hopefully merged in at some point), you'll need to use the patch here made by @ershov.andrey.

I can confirm the changes do what @scott_euser states in comment 36, marking as RTBC.

@scott_euser any chance to merge this and tag a new release? This is a really annoying thing not having the control about views title output.

Thanks!

Static patch attached until this is merged.

Thanks everyone! It doesn't contain the new feature described in #2 but does contain the bugfix. The separate feature described in #2 I think would need to be a separate views reference plugin as its a different behaviour than 'Include the view title' describes. But to note, would like to keep viewsreference simple without too many plugins, so consider viewsreference_extras or just own plugin if you want that feature still.

Thanks all

In terms of release, I'd like to get #3578487: Compatibility with Drupal 11.3.0 AJAX History: Relationships fail and crash field rendering on page reload in + #3583101: Upgrade to OOP hooks, php attributes, and other deprecation resolving after that. If anyone is willing to help, particularly testing the former. The latter should be quite quick to do and not need any notable back and forth.

Note that i had to resave my viewsreference field settings to have the title hiddenwith "Include View Title" unchecked, it's possible that it was just the consequence of a previouly applied patch for this same issue.

Leading to this config change :

--- a/config/sync/field.field.paragraph.view.field_pa_view.yml
+++ b/config/sync/field.field.paragraph.view.field_pa_view.yml
@@ -27,5 +27,4 @@ settings:
   preselect_views: {  }
   enabled_settings:
     argument: argument
-    title: true
 field_type: viewsreference

Very possible, earlier patches were quite different than what was merged

Re #51 no it does not unfortunately per my comment in #44. The problem with this original bug is it resulted in people using the buggy state like #3585918: Provide sample update hook to auto-tick 'Include the view title' for existing views reference field uses so there is no perfect world where some people don't have to have a post update script.

For getting your proposed control in however that'd not have that problem, because with 'Include the view title' ticked, if we eg renamed it to like 'View title display inclusion' as long as enabled + default setting would include the view title, your additional proposed feature could be added.

Given the problematic nature of the original issue (in that some sites expect title shown/others don't expect title shown) I think as maintainers we should be okay to add in such a feature to that plugin (even though I've heard from other maintainers the desire to effectively push any new plugin to eg views reference extras and keep this focused on the core functionality only) so unless other maintainers disagree, I'm personally happy for someone to make a followup to add your suggestions in (as long as it includes test coverage as well).

At this stage I had prioritised fixing the bug itself to avoid further people having diverging expectations of the default state (ie the title + issue summary of this issue). But yeah as I noted in that other issue, given some relied on the bug, others relied on the patch, there was no pleasing everyone there it seems. Tricky one!