Cloning Entities with Layout Paragraphs (1.x) breaks structure and moves subparagraphs into Disabled Items

Ok I finally found a hack to make this work and documented in the related layout_paragraphs issue to discuss how to solve this cleanly (in layout_paragraphs). Best would be to have a hook on

/**
   * Clone the paragraphs of an entity.
   *
   * If we do not clone the paragraphs attached to the entity, the linked
   * paragraphs would be linked to two entities which is not ideal.
   *
   * @param \Drupal\Core\Entity\ContentEntityInterface $entity
   *   The entity to clone paragraphs for.
   *
   * @return \Drupal\Core\Entity\ContentEntityInterface $entity
   *   The entity with cloned paragraph fields.
   */
  public function cloneParagraphs(ContentEntityInterface $entity) {
    foreach ($entity->getFieldDefinitions() as $field_definition) {
      $field_storage_definition = $field_definition->getFieldStorageDefinition();
      $field_settings = $field_storage_definition->getSettings();
      $field_name = $field_storage_definition->getName();
      if (isset($field_settings['target_type']) && $field_settings['target_type'] == "paragraph") {
        if (!$entity->get($field_name)->isEmpty()) {
          // TODO: Layout Paragraphs integration:
          // TODO: See https://www.drupal.org/project/layout_paragraphs/issues/3218226#comment-14129846
          // TODO: See https://www.drupal.org/project/quick_node_clone/issues/3218222
          // TODO: All the Steps 1-6 don't belong here in a perfect world but belong to layout_paragraphs
          // 1. Create helper array to store old / new uuids from all paragraphs
          // to update parent_uuids from all children later here:
          $uuidOldNewMap = [];

          foreach ($entity->get($field_name) as $value) {
            if ($value->entity) {
              // 2. Store the old uuid of this paragraph:
              $oldUuid = $value->entity->uuid();
              $value->entity = $value->entity->createDuplicate();
              // 3. Store the new uuid of this paragraph:
              $newUuid = $value->entity->uuid();
              // 4. Save old => new uuid relations in array to replace the old one later:
              $uuidOldNewMap[$oldUuid] = $newUuid;

              foreach ($value->entity->getFieldDefinitions() as $field_definition) {
                $field_storage_definition = $field_definition->getFieldStorageDefinition();
                $pfield_settings = $field_storage_definition->getSettings();
                $pfield_name = $field_storage_definition->getName();

                // Check whether this field is excluded and if so unset.
                if ($this->excludeParagraphField($pfield_name, $value->entity->bundle())) {
                  unset($value->entity->{$pfield_name});
                }

                $this->moduleHandler->alter('cloned_node_paragraph_field', $value->entity, $pfield_name, $pfield_settings);

                if (isset($pfield_settings['target_type']) && $pfield_settings['target_type'] == "paragraph" && !empty($value->entity->{$pfield_name})) {
                  // Do the same for any nested paragraphs.
                  self::cloneParagraphs($value->entity);
                }
              }

              // 5. Update children paragraphs parent_uuid's to the new uuids from
              // the cloned paragraphs:
              $behavior_settings = $value->entity->getAllBehaviorSettings();
              if(!empty($behavior_settings['layout_paragraphs']['parent_uuid'])){
                $oldParentUuid = $behavior_settings['layout_paragraphs']['parent_uuid'];
                if(!empty($uuidOldNewMap[$oldParentUuid])){
                  $newParentUuid = $uuidOldNewMap[$oldParentUuid];
                  $behavior_settings['layout_paragraphs']['parent_uuid'] = $newParentUuid;
                  // kint([$oldParentUuid, $newParentUuid]);
                  $value->entity->setBehaviorSettings('layout_paragraphs', $behavior_settings['layout_paragraphs']);
                }
              }

              // 6. TODO: All steps 1-5 don't belong here but
            }
          }
        }
      }
    }

    return $entity;
  }

@Maintainer: Shell we create an encapsulated fix in Quick Node Clone until this is possible?

This issue also needs MR1 from #3183249: Nested paragraph support - I included it in my MR here now to make it easier to test and review. We may have to reroll it once that issue has been fixed.

Thanks @Damien! :) Finally (for Quick Node Clone maintainers) we should try to find out, what's (and if) still needed for layout_paragraphs:^2 and leave a note here.

layout_paragraphs:^2 is definitely the future, so I think this issue may never be committed, but kept as working workaround for layout_paragraphs:^1 users.

For that reason I'm setting this back to "Needs work" - for such documentation and testing here.

As layout_paragraphs 2 is out and stable now, it would be great, if someone could pick this up and finish it. :)

@DamienMcKenna is #14 meant for Layout Paragraphs 2?
We should clarify this here and which steps need to be taken to make this bulletproof.

Being able to clone entities is an essential feature for content editors.

EDIT:

Here's the MR in patch format.

Sorry! I now saw it's just a static copy of the MR! So forget about my question. Still I'm unsure if it's still needed for LP2?!

Thanks @DamienMcKenna and sorry for my dumb question. So does anyone know if this issue or #3183249: Nested paragraph support is still required for Paragraphs or Layout Paragraphs 2?

Would be super nice to close this chapter.

Patch #14 does not apply anymore with latest quick_node_clone. So should we maybe close this and switch over to #3306081: Support cloning of paragraphs by integrating with popular contributed clone/replicate modules?

Just ran into this again and can confirm that this patch is still needed to work with (layout) paragraphs! So would be great, if the maintainer could decide how to proceed finally. This is an issue since many years... Thanks!

@grevil: Could you finish the work here please? I removed the draft state. Maybe you could also try contacting the maintainer on Slack if the fix is fine, so we can finally get this committed?

@thomas.frobieter can tell from TT if this works as expected.

Latest rebase from MR!3 attached as static patch!

Sadly have to confirm the patch doesn't work any more, the LB layouts are cloned, but shown empty.

Update:
For anyone using Layout Paragraphs 2.x or 3.x - forget about this issue and the patches here.
See #3218226: Cloning Entities containing Layout Paragraphs breaks structure and help pushing things forward!

As I think not many people are using LB 1.x any more, we should probably close this and focus on a clean solution in layout_paragraphs:

FYI: New hooks hook_entity_duplicate() and hook_ENTITY_TYPE_duplicate() have been committed to Drupal core and will be available in Drupal 11.2. A universal approach that works for all the cloning modules might be possible using those hooks, when sites are running 11.2+.

See #31 in #3218226: Cloning Entities containing Layout Paragraphs breaks structure