Problem/Motivation

PHPCompatibility detected the following warnings in backup_migrate.module:

FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
1558 | WARNING | INI directive 'safe_mode' is deprecated since PHP
| | 5.3 and removed since PHP 5.4
1923 | WARNING | INI directive 'safe_mode' is deprecated since PHP
| | 5.3 and removed since PHP 5.4
1983 | WARNING | INI directive 'safe_mode' is deprecated since PHP
| | 5.3 and removed since PHP 5.4

Steps to reproduce

  • Go to your backup_migrate directory for example: /sites/all/modules/contrib/backup_migrate.
  • Run phpcs:
    phpcs -p . --standard=PHPCompatibility --extensions=php,module,inc,install,test,profile,theme --runtime-set testVersion 7.3

Proposed resolution

Making a patch.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#6 backup_migrate-php74-3215180-6.patch1.69 KBhey_germano
#3 backup_migrate-safe_mode_depreceted-3215180-3.patch1.44 KBmibfire

Comments

mibfire created an issue. See original summary.

mibfire’s picture

mibfire commented
Issue summary: View changes
mibfire’s picture

mibfire commented
StatusFileSize
new backup_migrate-safe_mode_depreceted-3215180-3.patch1.44 KB

I made a patch to fix the issue.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 7.x-3.6 » 7.x-3.x-dev
Category: Bug report » Task
Status: Active » Needs review

Oh, that's a nice bit of cleanup. Let's see what the testbot thinks.

mibfire’s picture

mibfire commented
Issue summary: View changes
hey_germano’s picture

hey_germano
she/her
Primary language English
Location Minneapolis, MN, USA
commented
StatusFileSize
new backup_migrate-php74-3215180-6.patch1.69 KB

Here's a patch that should apply against 7.x-3.x-dev and also removes mentions of safe_mode from code comments.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3159271: Plan for Backup and Migrate 7.x-3.10

  • DamienMcKenna committed 8ff70eb on 7.x-3.x authored by mibfire 
    Issue #3215180 by mibfire, hey_germano, DamienMcKenna: INI directive '...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

This makes complete sense, thank you. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.